Skip to content

diebahn: 2.7.3 -> 2.8.1#407140

Merged
getchoo merged 1 commit intoNixOS:staging-nextfrom
dotlambda:diebahn
May 15, 2025
Merged

diebahn: 2.7.3 -> 2.8.1#407140
getchoo merged 1 commit intoNixOS:staging-nextfrom
dotlambda:diebahn

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented May 14, 2025

Diff: https://gitlab.com/schmiddi-on-mobile/railway/-/compare/refs/tags/2.7.3...2.8.1

Changelog: https://gitlab.com/schmiddi-on-mobile/railway/-/blob/2.8.1/CHANGELOG.md

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 14, 2025
@ddogfoodd
Copy link
Contributor

ddogfoodd commented May 14, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 407140

x86_64-linux

✅ 1 package built:
  • diebahn

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 14, 2025
getchoo
getchoo approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@getchoo getchoo added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels May 15, 2025
@getchoo getchoo merged commit 6a1f949 into NixOS:staging-next May 15, 2025
21 of 23 checks passed
@dotlambda dotlambda deleted the diebahn branch May 15, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@getchoo getchoo getchoo approved these changes

@michaelgrahamevans michaelgrahamevans Awaiting requested review from michaelgrahamevans

@Lilacious Lilacious Awaiting requested review from Lilacious

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

+1 more reviewer

@ddogfoodd ddogfoodd ddogfoodd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dotlambda @ddogfoodd @getchoo @wegank