compress-man-pages: optimize, use multiple cores#406922
Merged
Mic92 merged 1 commit intoNixOS:stagingfrom May 15, 2025
Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 5001+
Member
|
Mic92
reviewed
May 14, 2025
Mic92
reviewed
May 14, 2025
Decreases the time spent on gzipping man pages. Decreases the number of processes launched per file from 2 to 1. Launches multiple processes in parallel via xargs -P. The behavior of the hook is unchanged. gzip -f is now needed to retain the behavior of compressing hardlinkgs. Previously '-f' was not needed because gzip compressed to stdout. It removes the check checking if gzip failed, because there os no reason it should ever fail. Even if it fails we probably want to fix the issue instead of silently not gzipping. This check has been introduced via c06046e. No comment was given on why it would be necessary.
Member
Author
|
Pushed another change with further optimization. It now calls gzip directly instead of going through an extra shell. |
Member
|
13 tasks
This was referenced Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decreases the time spent on gzipping man pages.
Decreases the number of processes launched per file from 2 to 1.
Launches multiple processes in parallel via xargs -P.
The behavior of the hook is unchanged.
gzip -f is now needed to retain the behavior of compressing hardlinkgs.
Previously '-f' was not needed because gzip compressed to stdout.
It removes the check checking if gzip failed, because there os no reason it should ever fail.
Even if it fails we probably want to fix the issue instead of silently not gzipping.
This check has been introduced via c06046e.
No comment was given on why it would be necessary.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.