snappy: 1.2.1 -> 1.2.2 (take 2)#406663
Merged
pbsds merged 1 commit intoNixOS:stagingfrom Jun 11, 2025
Merged
Conversation
This time we revert interface changes to not break `arrow-cpp` and others. Changes: https://github.com/google/snappy/releases/tag/1.2.2
github-actions
bot
added
10.rebuild-darwin: 501+
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Member
|
arrow-cpp builds when cherry-picked on master 👍 |
nh2
reviewed
Jul 25, 2025
| # Re-enable RTTI, without which other applications can't subclass | ||
| # snappy::Source (this breaks Ceph, as one example) | ||
| # https://tracker.ceph.com/issues/53060 | ||
| # https://build.opensuse.org/package/show/openSUSE:Factory/snappy |
Contributor
There was a problem hiding this comment.
@trofi coming from
should this patch no longer be necessary?
I do not immediately understand the relation between the revert-PUBLIC.patch and the previous RTTI patch.
Contributor
Author
There was a problem hiding this comment.
There is no relation between the patches. revert-PUBLIC.patch comes from google/snappy#206 (comment)
I think (I don't remember' sorry) I removed the RTTI patch because it was rejected upstream google/snappy#144 and was failing to apply downstream.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This time we revert interface changes to not break
arrow-cppand others.Changes: https://github.com/google/snappy/releases/tag/1.2.2
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.