Skip to content

ceph: Work around broken build with arrow-cpp >= 20#406483

Merged
nh2 merged 1 commit intoNixOS:masterfrom
nh2:issue-406306-revive-arrow-19-for-ceph
May 13, 2025
Merged

ceph: Work around broken build with arrow-cpp >= 20#406483
nh2 merged 1 commit intoNixOS:masterfrom
nh2:issue-406306-revive-arrow-19-for-ceph

Conversation

@nh2
Copy link
Contributor

@nh2 nh2 commented May 12, 2025

Fixes #406306.

Does not change the eval, so it built from the binary cache.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nh2 nh2 requested review from benaryorg and ryand56 May 12, 2025 15:18
@nh2 nh2 mentioned this pull request May 12, 2025
3 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 12, 2025
@benaryorg
Copy link
Contributor

Can confirm that f73c067 (this PR) and 1b11fd8 (commit before arrow 20.0.0 in e59c1b4) both evaluate to /nix/store/lmh5aw90q0xg412z18g1092j4sgvzqh5-ceph-19.2.2 on x86_64-linux, making this a no-op fixing the build.

Copy link
Member

@ryand56 ryand56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 406483
Commit: f73c0679d112e6026d16cf74524fc33129b7402b


x86_64-linux

✅ 14 packages built:
  • ceph (ceph-dev)
  • ceph-client
  • ceph-csi
  • ceph.dev (ceph-dev.dev)
  • ceph.doc (ceph-dev.doc)
  • libceph (ceph.lib, libceph.dev, libceph.doc, libceph.lib, libceph.man)
  • ceph.man (ceph-dev.man)
  • qemu_full
  • qemu_full.debug
  • qemu_full.doc
  • qemu_full.ga
  • sambaFull (samba4Full)
  • sambaFull.dev (samba4Full.dev)
  • sambaFull.man (samba4Full.man)

LGTM

@ryand56 ryand56 added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 12, 2025
@nh2 nh2 merged commit 6240366 into NixOS:master May 13, 2025
22 of 23 checks passed
@ccicnce113424 ccicnce113424 mentioned this pull request Jul 19, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: ceph

3 participants