Merged
Conversation
13 tasks
pkgs/by-name/xw/xwax/package.nix
Outdated
Comment on lines
38
to
39
Member
There was a problem hiding this comment.
Shouldn't be using lib.getExe pkg instead of ${lib.getBin pkg}/bin/...?
Contributor
Author
There was a problem hiding this comment.
Sounds good. Changed to:
--- a/pkgs/by-name/xw/xwax/package.nix
+++ b/pkgs/by-name/xw/xwax/package.nix
@@ -35,8 +35,8 @@ stdenv.mkDerivation (finalAttrs: {
# make paths to executed binaries hermetic:
substituteInPlace import \
- --replace-fail "exec cdparanoia" "exec ${lib.getBin cdparanoia}/bin/cdparanoia" \
- --replace-fail "exec ffmpeg" "exec ${lib.getBin ffmpeg}/bin/ffmpeg"
+ --replace-fail "exec cdparanoia" "exec ${lib.getExe cdparanoia}" \
+ --replace-fail "exec ffmpeg" "exec ${lib.getExe ffmpeg}"
'';
buildInputs = [
github-actions
bot
added
10.rebuild-darwin: 0
Without the change user needs to supply their own importer and scanner. Discovered in NixOS#402378 (comment)
Member
|
Member
|
Importing/Scanning works, a but lost on how to test it further |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the change user needs to supply their own importer and scanner. Discovered in #402378 (comment)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.