Skip to content

snappy: revert "1.2.1 -> 1.2.2"#405879

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
trofi:snappy-revert
May 10, 2025
Merged

snappy: revert "1.2.1 -> 1.2.2"#405879
vcunat merged 1 commit intoNixOS:staging-nextfrom
trofi:snappy-revert

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented May 10, 2025 •
edited
Loading

This reverts commit f8f070b.

Update caused arrow-cpp build regression: https://hydra.nixos.org/build/296807834/nixlog/2/tail

CMake Error at src/arrow/CMakeLists.txt:616 (target_link_libraries):
Cannot find source file:

  /nix/store/b89ii782h8lna88nwrna05pchccx2rpk-snappy-1.2.2/include/snappy-c.h

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@trofi
snappy: revert "1.2.1 -> 1.2.2"
3b0374e 
This reverts commit f8f070b.

Update caused `arrow-cpp` build regression: https://hydra.nixos.org/build/296807834/nixlog/2/tail

  CMake Error at src/arrow/CMakeLists.txt:616 (target_link_libraries):
    Cannot find source file:

      /nix/store/b89ii782h8lna88nwrna05pchccx2rpk-snappy-1.2.2/include/snappy-c.h
@trofi trofi mentioned this pull request May 10, 2025
Merged
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels May 10, 2025
@nyabinary
Copy link
Contributor

nyabinary commented May 10, 2025

Ignoring the bots arrow-cpp hasn't been updated to 20.00 maybe that fixes the issue?

@nim65s
Copy link
Contributor

nim65s commented May 10, 2025

arrow-cpp was update to 20.00: #404894

@trofi
Copy link
Contributor Author

trofi commented May 10, 2025

Yeah, staging-next already has 20.0 and fail the same without the revert.

@nyabinary
Copy link
Contributor

nyabinary commented May 10, 2025

Very weird considering their bundled version already has 1.2.2?
apache/arrow#45981

@vcunat
Copy link
Member

vcunat commented May 10, 2025 •
edited
Loading

I believe I see what's wrong. I looked at diffs of the ./result-dev/, and in snappy-1.2.2-dev/lib/cmake/Snappy/SnappyTargets.cmake they added an INTERFACE_SOURCES line that assumes everything is in a single prefix (and in nixpkgs it is not). So those include files are then searched in .out instead of .dev and not found...

EDIT: that kind of thing might be worth fixing upstream.

@vcunat vcunat merged commit ac57430 into NixOS:staging-next May 10, 2025
34 of 35 checks passed
@trofi trofi deleted the snappy-revert branch May 10, 2025 16:24
@vcunat vcunat mentioned this pull request May 11, 2025
Open
@vcunat
Copy link
Member

vcunat commented May 11, 2025

I don't get what's going on here, but I notified upstream at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@trofi @nyabinary @nim65s @vcunat