nixpkgs-vet: init at 0.1.4#405853
Merged
philiptaron merged 1 commit intoNixOS:masterfrom May 10, 2025
Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 1
Contributor
Author
|
dtomvan
approved these changes
May 10, 2025
Contributor
dtomvan
left a comment
dtomvan
left a comment
There was a problem hiding this comment.
Rest LGTM. I hope this will make the nixpkgs-vet invocation a little simpler than the existing ci/nixpkgs-vet* scripts.
This is currently run in CI, but not from nixpkgs. Instead it's pulled from the upstream repo. There is only a x86_64-linux release, though, which makes this approach inadequate for local usage on other systems. We already use a pinned nixpkgs revision in CI, so we should move to use that for nixpkgs-vet, too. Shamelessly added philiptaron and willbush as the maintainers, because they have been actively maintaining the upstream package lately.
wolfgangwalther
force-pushed
the
nixpkgs-vet
branch
from
17c7193 to
15f90af
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is currently run in CI, but not from nixpkgs. Instead it's pulled from the upstream repo. There is only a x86_64-linux release, though, which makes this approach inadequate for local usage on other systems.
We already use a pinned nixpkgs revision in CI, so we should move to use that for nixpkgs-vet, too.
Shamelessly added @philiptaron and @willbush as the maintainers, because they have been actively maintaining the upstream package lately. Please confirm, whether you're OK with that.
Before we can make use of this in CI, we need to merge it and then bump the pinned nixpkgs revision.
Things done
Add a 👍 reaction to pull requests you find important.