We already have treefmt running for nixfmt, so it's easy to just add another formatter to it. This gives a much better UX, because all formatting errors are reported through the same channel.

It also saves us one CI job, which takes most of the time to just set up the machine, clone the repo and download Nix - while doing a minimum of actual work.

Total execution time for treefmt is ~10% slower:

• 39s only nixfmt
• 43s nixfmt + editorconfig-checker

Also, because we're not checking only changed files anymore, we're not going to have editorconfig failures sneak in over time as they did before.

Some raw numbers (AMD Ryzen 9 3950X 16-Core):

Benchmark 1: treefmt --ci
  Time (mean ± σ):     42.621 s ±  0.592 s    [User: 567.085 s, System: 30.949 s]
  Range (min … max):   41.897 s … 43.668 s    10 runs

Benchmark 2: treefmt --ci -f nixfmt
  Time (mean ± σ):     38.886 s ±  0.405 s    [User: 447.413 s, System: 12.945 s]
  Range (min … max):   38.052 s … 39.348 s    10 runs

Benchmark 3: treefmt --ci -f editorconfig-checker
  Time (mean ± σ):      6.963 s ±  0.139 s    [User: 116.637 s, System: 13.147 s]
  Range (min … max):    6.579 s …  7.035 s    10 runs

Actions Performance Metrics (avg run time):

• editorconfig-v2.yml: 54s
• check-nix-format.yml: 2m 24s

This will most likely have minimal effect on the runtime of the check-format workflow, but save the whole editorconfig-v2 workflow.

Things done

Tested locally.

• Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.