gnomeExtensions: include extensions for GNOME 48#405612
Merged
jtojnar merged 3 commits intoNixOS:staging-nextfrom May 10, 2025
Merged
gnomeExtensions: include extensions for GNOME 48#405612jtojnar merged 3 commits intoNixOS:staging-nextfrom
jtojnar merged 3 commits intoNixOS:staging-nextfrom
Conversation
github-actions
bot
added
the
6.topic: GNOME
Member
|
I guess we either need to remove the pano override, convert it to manually packaged extension, or keep GNOME 45 merged into the set. |
Member
|
Also, we should probably sort the collisions by --- a/pkgs/desktops/gnome/extensions/update-extensions.py
+++ b/pkgs/desktops/gnome/extensions/update-extensions.py
@@ -351,7 +351,7 @@ def find_collisions(
package_name_registry.setdefault(pname, set()).add(uuid)
return {
pname: sorted(uuids)
- for pname, uuids in package_name_registry.items()
+ for pname, uuids in sorted(package_name_registry.items(), key=itemgetter(0))
if len(uuids) > 1
}
|
Contributor
Author
|
I still don't know why the order is changing. Fixed it anyway by sorting the items.. |
github-actions
bot
added
10.rebuild-darwin: 0
jtojnar
reviewed
May 10, 2025
jtojnar
reviewed
May 10, 2025
honnip
force-pushed
the
gnomeExtensions/gnome48
branch
2 times, most recently
from
928c973 to
784c807
Compare
jtojnar
reviewed
May 10, 2025
jtojnar
reviewed
May 10, 2025
It's been a while since the Pano extension has been uploaded to EGO, and it's not in gnomeExtensions set after GNOME 48. So, package it manually.
Member
In Python, the dictionaries are ordered based on the order of insertion. Since the , {"uuid": "Fuzzy_Clock@dallagi", "pname": "fuzzy-clock", "link": "https://extensions.gnome.org/extension/202/fuzzy-clock/", "shell_version_map": { "38": {} } }
, {"uuid": "[email protected]", "pname": "fuzzy-clock", "link": "https://extensions.gnome.org/extension/1281/fuzzy-clock/", "shell_version_map": { "38": {}, "40": {}, "41": {}, "42": {}, "43": {}, "45": {} } }
, {"uuid": "[email protected]", "pname": "battery-time", "link": "https://extensions.gnome.org/extension/1475/battery-time/", "shell_version_map": { "40": {}, "41": {}, "42": {}, "43": {}, "44": {}, "45": {}, "46": {}, "47": {}, "48": {} } }
, {"uuid": "FuzzyClock@johngoetz", "pname": "fuzzy-clock", "link": "https://extensions.gnome.org/extension/4771/fuzzy-clock/", "shell_version_map": { "40": {}, "41": {}, "42": {}, "43": {}, "44": {}, "45": {}, "46": {}, "47": {} } }
, {"uuid": "[email protected]", "pname": "battery-time", "link": "https://extensions.gnome.org/extension/5425/battery-time/", "shell_version_map": { "43": {}, "44": {}, "45": {}, "46": {}, "47": {}, "48": {} } }
, {"uuid": "FuzzyClock@fire-man-x", "pname": "fuzzy-clock", "link": "https://extensions.gnome.org/extension/7056/fuzzy-clock/", "shell_version_map": { "45": {}, "46": {}, "47": {}, "48": {} } }
, {"uuid": "[email protected]", "pname": "battery-time", "link": "https://extensions.gnome.org/extension/7999/battery-time/", "shell_version_map": { "47": {}, "48": {} } } |
Contributor
Author
|
Ah I see, so it makes sense to sort by pname rather than the id, as we did here |
honnip
force-pushed
the
gnomeExtensions/gnome48
branch
from
784c807 to
8d62d25
Compare
honnip
force-pushed
the
gnomeExtensions/gnome48
branch
from
8d62d25 to
e3e9b33
Compare
Member
|
Thank you. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gnomeExtensionsset includes extensions for GNOME 46, 47, and 48.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.