Skip to content

python3Packages.pyarrow: add orc#405543

Merged
veprbl merged 4 commits intoNixOS:masterfrom
nim65s:pyarrow-orc
Jun 4, 2025
Merged

python3Packages.pyarrow: add orc#405543
veprbl merged 4 commits intoNixOS:masterfrom
nim65s:pyarrow-orc

Conversation

@nim65s
Copy link
Contributor

@nim65s nim65s commented May 9, 2025 •
edited
Loading

This include #404894 (merged & rebased)
Fix #212863

tried usage as described in https://orc.apache.org/docs/pyarrow.html with success.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 9, 2025
@nim65s nim65s mentioned this pull request May 9, 2025
Merged
13 tasks
@nim65s nim65s changed the title python3Packages.pyarrow: add orc, fix #212863 python3Packages.pyarrow: add orc May 9, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels May 9, 2025
@nix-owners nix-owners bot requested review from cpcloud, tobim and veprbl May 9, 2025 11:24
@nim65s nim65s marked this pull request as draft May 9, 2025 11:35
@nim65s nim65s changed the base branch from staging to master May 9, 2025 11:37
@nim65s nim65s marked this pull request as ready for review May 9, 2025 11:38
@nim65s nim65s mentioned this pull request May 9, 2025
Merged
13 tasks
aciceri
aciceri approved these changes May 10, 2025
View reviewed changes
Copy link
Member

@aciceri aciceri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, I've tried using this in #403107 and seems to work.

nim65s added 4 commits May 10, 2025 11:43
@nim65s
arrow-cpp: ignore one more test
4a80f62
@nim65s
arrow-cpp: update for protobuf 30
62fb31e 
fix:
arrow-cpp> /nix/store/wcv8n2k53w8sbffpf716gxj6mjb5jf26-binutils-2.44/bin/ld: release/libarrow.so.1900.1.0: undefined reference to `google::protobuf::internal::fixed_address_empty_string'
arrow-cpp> collect2: error: ld returned 1 exit status
@nim65s
arrow-cpp: enable Apache ORC
93e2668
@nim65s
python3Packages.pyarrow: check orc import
493cbcc
@nim65s
Copy link
Contributor Author

nim65s commented May 10, 2025

Rebased after the merge of #404894, and reordered the commits anti-chronologically to ease bisects.

veprbl
veprbl approved these changes May 10, 2025
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.approvals: 2 This PR was reviewed and approved by two persons. labels May 11, 2025
tobim
tobim approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine. Closure size increases by 1.8Mb. Nothing unexpected.

@veprbl veprbl merged commit 8355f8e into NixOS:master Jun 4, 2025
25 checks passed
@nim65s nim65s deleted the pyarrow-orc branch June 4, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@veprbl veprbl veprbl approved these changes

@cpcloud cpcloud Awaiting requested review from cpcloud

+2 more reviewers

@tobim tobim tobim approved these changes

@aciceri aciceri aciceri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Python pyarrow should include orc support

5 participants

@nim65s @veprbl @tobim @aciceri @wegank