[24.11]: ci/eval/compare: support optional byName argument#405159
Merged
wolfgangwalther merged 3 commits intoNixOS:release-24.11from May 8, 2025
Merged
[24.11]: ci/eval/compare: support optional byName argument#405159wolfgangwalther merged 3 commits intoNixOS:release-24.11from
wolfgangwalther merged 3 commits intoNixOS:release-24.11from
Conversation
github-actions
bot
added
6.topic: continuous integration
nix-owners
bot
requested review from
LeSuisse,
infinisil,
mweinelt,
philiptaron and
risicle
13 tasks
github-actions
bot
added
10.rebuild-darwin: 0
numinit
reviewed
May 8, 2025
We need to pass through the maintainers and teams positions from the original meta so pings work correctly, since check-meta clobbers the original attribute positions in them. Tested with `maintainers/scripts/get-maintainer-pings-between.sh` on a handful of major packages maintained by both individuals and teams. (cherry picked from commit 92bd743)
wolfgangwalther
force-pushed
the
backport-394797-402991-ci
branch
from
4ce6c87 to
fe49b3c
Compare
wolfgangwalther
commented
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports parts of #394797 and #402991 - purely for the cause of "we want no diff in workflows/ and ci/ to make backporting other changes easier".
My understanding is that those changes won't do much on stable, because there are no script using the argument, but they should also not do harm. Agreed, @winterqt?
Things done
Add a 👍 reaction to pull requests you find important.