Skip to content

release.nix: don't use special treatment for more package sets#405039

Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom
jopejoe1:cleanup-realese
Aug 8, 2025
Merged

release.nix: don't use special treatment for more package sets#405039
wolfgangwalther merged 1 commit intoNixOS:masterfrom
jopejoe1:cleanup-realese

Conversation

@jopejoe1
Copy link
Member

@jopejoe1 jopejoe1 commented May 7, 2025 •
edited
Loading

We have recurseForDerivations so lets make use of that and not do some special treatment.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from jtojnar May 7, 2025 19:56
@github-actions github-actions bot added 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels May 7, 2025
@jopejoe1 jopejoe1 force-pushed the cleanup-realese branch 2 times, most recently from 4fe6bba to 5160587 Compare July 25, 2025 21:30
@jopejoe1 jopejoe1 changed the base branch from master to staging July 25, 2025 21:30
@nixpkgs-ci nixpkgs-ci bot closed this Jul 25, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Jul 25, 2025
@jopejoe1 jopejoe1 requested a review from wolfgangwalther July 25, 2025 21:40
wolfgangwalther
wolfgangwalther reviewed Aug 4, 2025
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with release.nix, yet, but I think this is the right direction. Hopefully we can do the same for ocamlPackages eventually, too...

I'd like to understand the "removed packages" before we merge this, though.

@wolfgangwalther wolfgangwalther mentioned this pull request Aug 6, 2025
Merged
2 tasks
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 7, 2025
@jopejoe1 jopejoe1 changed the base branch from staging to master August 8, 2025 09:53
@nixpkgs-ci nixpkgs-ci bot closed this Aug 8, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Aug 8, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. labels Aug 8, 2025
wolfgangwalther
wolfgangwalther reviewed Aug 8, 2025
View reviewed changes
wolfgangwalther
wolfgangwalther approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this!

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 8, 2025
@wolfgangwalther wolfgangwalther merged commit 47db24f into NixOS:master Aug 8, 2025
25 of 28 checks passed
@jopejoe1 jopejoe1 deleted the cleanup-realese branch August 17, 2025 15:13
@jopejoe1 jopejoe1 mentioned this pull request Aug 19, 2025
Closed
13 tasks
@wolfgangwalther wolfgangwalther mentioned this pull request Sep 2, 2025
Merged
@wolfgangwalther wolfgangwalther added the 8.has: port to stable This PR already has a backport to the stable release. label Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vcunat vcunat vcunat left review comments

@emilazy emilazy emilazy left review comments

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees

No one assigned

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jopejoe1 @vcunat @wolfgangwalther @emilazy