Skip to content

arrow-cpp: 19.0.1 -> 20.0.0#404894

Merged
veprbl merged 1 commit intoNixOS:masterfrom
tobim:pkgs/arrow-20
May 9, 2025
Merged

arrow-cpp: 19.0.1 -> 20.0.0#404894
veprbl merged 1 commit intoNixOS:masterfrom
tobim:pkgs/arrow-20

Conversation

@tobim
Copy link
Contributor

@tobim tobim commented May 7, 2025

https://arrow.apache.org/release/20.0.0.html

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels May 7, 2025
@nix-owners nix-owners bot requested review from cpcloud and veprbl May 7, 2025 11:42
veprbl
veprbl approved these changes May 8, 2025
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 8, 2025
@nim65s nim65s mentioned this pull request May 9, 2025
Merged
13 tasks
nim65s
nim65s suggested changes May 9, 2025
View reviewed changes
Copy link
Contributor

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This trigger more than 500 rebuilds, so I guess this should be targeting stagging:
https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#changes-causing-mass-rebuilds

Any reason not do to so ?

@kirillrdy
Copy link
Member

kirillrdy commented May 9, 2025 •
edited
Loading

there are many cases when large number doesn't mean it takes too long to rebuild to target master, eg vim-plugins, ruby-gems.

can't speak for arrow-cpp, but looks like at least last two merges targeted master, so probably not a problem

nim65s
nim65s approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff lgtm, an I tried this with success within #405543

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels May 9, 2025
@veprbl veprbl merged commit e59c1b4 into NixOS:master May 9, 2025
31 checks passed
@nim65s nim65s mentioned this pull request May 10, 2025
Merged
13 tasks
@benaryorg
Copy link
Contributor

benaryorg commented May 12, 2025

I would like to note that at the time this PR was created we had already reached the "Restrict all breaking changes" phase of the NixOS 25.05 release (which is fine since it's a PR).
Given that the 20.0.0 release is by definition a breaking change because upstream follows SemVer this could've targeted staging instead, and get merged within the past five days since staging is unrestricted since, and a potential backport would then have the ability to be handled without potentially breaking packages during the distro release cycle.
Again, opening PRs is fine, and even merging isn't that big a deal, but please be a bit more careful when merging 500+ rebuild PRs for major version changes during this phase.

@jemand771
Copy link
Member

jemand771 commented May 12, 2025

arrived here from a quick git bisect run nix-build -A python312Packages.awkward1; this update seems to have broken python3.1{2,3}-awkward-2.8.1-dist on all platforms :/

I don't personally care about either of these packages, just looking for low-hanging zhf fruit and letting you know 👀

Footnotes

  1. I know that way isn't entirely correct; I've manually verified the results in this case ↩

@tobim
Copy link
Contributor Author

tobim commented May 13, 2025

This has been fixed in #404148 now.

@tobim tobim deleted the pkgs/arrow-20 branch May 13, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@veprbl veprbl veprbl approved these changes

@cpcloud cpcloud Awaiting requested review from cpcloud

+1 more reviewer

@nim65s nim65s nim65s approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tobim @kirillrdy @benaryorg @jemand771 @nim65s @veprbl @wegank