Skip to content

libglvnd: set -Wno-error=array-bounds #40432

Merged
xeji merged 1 commit intoNixOS:gcc8from
Synthetica9:gcc8-libglvnd-fix
May 13, 2018
Merged

libglvnd: set -Wno-error=array-bounds #40432
xeji merged 1 commit intoNixOS:gcc8from
Synthetica9:gcc8-libglvnd-fix

Conversation

@Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented May 13, 2018 •
edited
Loading

Motivation for this change

It was broken without: https://hydra.nixos.org/build/73825633

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels May 13, 2018
@GrahamcOfBorg
Copy link

GrahamcOfBorg commented May 13, 2018

Failure on x86_64-linux (full log)

Attempted: nasm

Partial log (click to expand)

gcc -c -g -O3 -fwrapv -U__STRICT_ANSI__ -fno-common -Werror=attributes -W -Wall -pedantic -Wc90-c99-compat -Wno-long-long -Werror=implicit -Werror=missing-braces -Werror=return-type -Werror=trigraphs -Werror=pointer-arith -Werror=missing-prototypes -Werror=missing-declarations -Werror=comment -Werror=vla -DHAVE_CONFIG_H -I. -I. -I./include -I./include -I./x86 -I./x86 -I./asm -I./asm -I./disasm -I./disasm -I./output -I./output -o asm/nasm.o asm/nasm.c
In file included from ./include/nasm.h:46,
                 from asm/nasm.c:47:
./include/nasmlib.h:194:1: error: 'pure' attribute on function returning 'void' [-Werror=attributes]
 void pure_func seg_init(void);
 ^~~~
cc1: some warnings being treated as errors
make: *** [Makefile:75: asm/nasm.o] Error 1
builder for '/nix/store/q1ll3km6l5crfz1sjb8ixfpwd8v5iq6m-nasm-2.13.03.drv' failed with exit code 2
error: build of '/nix/store/q1ll3km6l5crfz1sjb8ixfpwd8v5iq6m-nasm-2.13.03.drv' failed

@GrahamcOfBorg
Copy link

GrahamcOfBorg commented May 13, 2018

Failure on aarch64-linux (full log)

Attempted: nasm

Partial log (click to expand)

gcc -c -g -O3 -fwrapv -U__STRICT_ANSI__ -fno-common -Werror=attributes -W -Wall -pedantic -Wc90-c99-compat -Wno-long-long -Werror=implicit -Werror=missing-braces -Werror=return-type -Werror=trigraphs -Werror=pointer-arith -Werror=missing-prototypes -Werror=missing-declarations -Werror=comment -Werror=vla -DHAVE_CONFIG_H -I. -I. -I./include -I./include -I./x86 -I./x86 -I./asm -I./asm -I./disasm -I./disasm -I./output -I./output -o asm/nasm.o asm/nasm.c
In file included from ./include/nasm.h:46,
                 from asm/nasm.c:47:
./include/nasmlib.h:194:1: error: 'pure' attribute on function returning 'void' [-Werror=attributes]
 void pure_func seg_init(void);
 ^~~~
cc1: some warnings being treated as errors
make: *** [Makefile:75: asm/nasm.o] Error 1
builder for '/nix/store/d722jywi6vg56acmwgnvl6dqbdp663g7-nasm-2.13.03.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/d722jywi6vg56acmwgnvl6dqbdp663g7-nasm-2.13.03.drv' failed

@Synthetica9 Synthetica9 changed the title nasm: set -Wno-error=array-bounds for libglvnd libglvnd: set -Wno-error=array-bounds May 13, 2018
@Synthetica9
Copy link
Member Author

Synthetica9 commented May 13, 2018

Whoops, wrong name

@GrahamcOfBorg
Copy link

GrahamcOfBorg commented May 13, 2018

Success on x86_64-linux (full log)

Attempted: libglvnd

Partial log (click to expand)

shrinking /nix/store/87yi2jy9qmhvb85rzd5pm3vyvgpcriv4-libglvnd-1.0.0/lib/libGLESv2.so.2.0.0
strip is /nix/store/85wqgd5aj4g57g1fsrnmdbq4mf1kz957-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/87yi2jy9qmhvb85rzd5pm3vyvgpcriv4-libglvnd-1.0.0/lib
patching script interpreter paths in /nix/store/87yi2jy9qmhvb85rzd5pm3vyvgpcriv4-libglvnd-1.0.0
checking for references to /build in /nix/store/87yi2jy9qmhvb85rzd5pm3vyvgpcriv4-libglvnd-1.0.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/x0bi3y8xwqkm42vx3wm6fxs90k8x1bch-libglvnd-1.0.0-dev
strip is /nix/store/85wqgd5aj4g57g1fsrnmdbq4mf1kz957-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/x0bi3y8xwqkm42vx3wm6fxs90k8x1bch-libglvnd-1.0.0-dev/lib
patching script interpreter paths in /nix/store/x0bi3y8xwqkm42vx3wm6fxs90k8x1bch-libglvnd-1.0.0-dev
checking for references to /build in /nix/store/x0bi3y8xwqkm42vx3wm6fxs90k8x1bch-libglvnd-1.0.0-dev...

@GrahamcOfBorg
Copy link

GrahamcOfBorg commented May 13, 2018

Success on aarch64-linux (full log)

Attempted: libglvnd

Partial log (click to expand)

strip is /nix/store/ks7k1wdljx2knaayzr528cwbj6v970km-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/v7w3x640d024y5m5g79wagir1xgpfyxq-libglvnd-1.0.0/lib
patching script interpreter paths in /nix/store/v7w3x640d024y5m5g79wagir1xgpfyxq-libglvnd-1.0.0
checking for references to /build in /nix/store/v7w3x640d024y5m5g79wagir1xgpfyxq-libglvnd-1.0.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/bxcrjahdi2viwxgrnhbwvgr088w8xyyn-libglvnd-1.0.0-dev
strip is /nix/store/ks7k1wdljx2knaayzr528cwbj6v970km-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bxcrjahdi2viwxgrnhbwvgr088w8xyyn-libglvnd-1.0.0-dev/lib
patching script interpreter paths in /nix/store/bxcrjahdi2viwxgrnhbwvgr088w8xyyn-libglvnd-1.0.0-dev
checking for references to /build in /nix/store/bxcrjahdi2viwxgrnhbwvgr088w8xyyn-libglvnd-1.0.0-dev...
/nix/store/v7w3x640d024y5m5g79wagir1xgpfyxq-libglvnd-1.0.0

@xeji
Copy link
Contributor

xeji commented May 13, 2018

The array bounds warning could indicate a serious bug in upstream code. Did you investigate this?

@Synthetica9
Copy link
Member Author

Synthetica9 commented May 13, 2018

It looks like a false positive to me. That being said, I'm not an upstream developer for that package; so I can't really guarantee it.

@xeji xeji merged commit 116cce8 into NixOS:gcc8 May 13, 2018
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
@adrianpk
libglvnd: set -Wno-error=array-bounds (NixOS#40432)
8396bc2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Synthetica9 @GrahamcOfBorg @xeji