workflows/backport: only trigger on backport labels#404132
Merged
Mic92 merged 1 commit intoNixOS:masterfrom May 4, 2025
Merged
workflows/backport: only trigger on backport labels#404132Mic92 merged 1 commit intoNixOS:masterfrom
Mic92 merged 1 commit intoNixOS:masterfrom
Conversation
The backport job was previously triggered on any label activity, i.e. when the backport label was already set and a new label added, the backport would have been triggered again. That's because github.event_name is actually "pull_request_target" in this case, not "closed" or "labeled" (the event's types). Thus, this part of the condition was always true. This also means that the second part, the startsWith, was never evaluated. It had its arguments flipped and would have always been false. This was introduced in NixOS#126825, but has never really worked as intended. Resolves NixOS#199556
github-actions
bot
added
6.topic: continuous integration
nix-owners
bot
requested review from
LeSuisse,
Mic92,
azuwis,
infinisil,
mweinelt,
risicle and
zowoq
github-actions
bot
added
10.rebuild-darwin: 0
kachick
reviewed
May 4, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backport job was previously triggered on any label activity, i.e. when the backport label was already set and a new label added, the backport would have been triggered again. (Example: #402332, where I tested that)
That's because
github.event_nameis actually "pull_request_target" in this case, not "closed" or "labeled" (the event's types). Thus, this part of the condition was always true.This also means that the second part, the startsWith, was never evaluated. It had its arguments flipped and would have always been false.
This was introduced in #126825, but has never really worked as intended. @zowoq already mentioned this in #126825 (comment)
Resolves #199556
Relevant docs:
Things done
Add a 👍 reaction to pull requests you find important.