[24.11]: workflows/labels: skip for staging-next / haskell-updates / python-updates#404107
Merged
wolfgangwalther merged 10 commits intoNixOS:release-24.11from May 4, 2025
Conversation
(cherry picked from commit 8ed4f7b)
…dates Labelling those PRs is more annoying then useful. (cherry picked from commit 1909520)
This adds some labels related to the higher level workflows of developing nixpkgs: - "4.workflow: backport" can be used to filter everything targeting the stable branches, both release-XX.YY or staging-XX.YY. - "4.workflow: package set updates" can be used to filter the haskell/python package set PRs. Can be combined with "6.topic: haskell" or "6.topic: python". - "4.workflow: staging" can be used to filter for all staging-next PRs, both to master and release branches. (cherry picked from commit 5ed0205)
github-actions
bot
added
6.topic: policy discussion
1 task
nix-owners
bot
requested review from
LeSuisse,
Mic92,
infinisil,
mweinelt,
risicle and
zowoq
github-actions
bot
added
10.rebuild-darwin: 0
Introduced in NixOS#402332, but broken on all ends: - pull_request needs to be event.pull_request - pull_request.head is an object, not a string - github.ref_protected is about the target branch, because this runs as a pull_request_target event Thus, we need to list the branches manually. (cherry picked from commit e676235)
Mic92
reviewed
May 4, 2025
Because GitHub Actions doesn't like double quotes. (cherry picked from commit 6cb93f2)
The backport job was previously triggered on any label activity, i.e. when the backport label was already set and a new label added, the backport would have been triggered again. That's because github.event_name is actually "pull_request_target" in this case, not "closed" or "labeled" (the event's types). Thus, this part of the condition was always true. This also means that the second part, the startsWith, was never evaluated. It had its arguments flipped and would have always been false. This was introduced in NixOS#126825, but has never really worked as intended. Resolves NixOS#199556 (cherry picked from commit b62d9a2)
This allows filtering for PRs with a backport label, but without the "has: port to stable" label to find those which need to be manually acted on. Resolves NixOS#325359 (cherry picked from commit fa154d1)
(cherry picked from commit b6375b2)
Somehow, the was_successful output didn't work correctly. It's hard to imagine that the created_pull_numbers output fails the same way, because... when the backport action fails there **are no pull request numbers**. (cherry picked from commit 2480e35)
Contributor
Author
|
Also added the other 4 PRs that I had earlier today, which didn't get the backport label automatically due to the temporary brokenness of the labeler action. |
(cherry picked from commit de670fa)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #402332 and parts of #374921.
I did not backport the configuration of backport labels for CI PRs from #374921... because otherwise we'd end up with backport labels on the backport PRs as well. On the same vein, we'll need to remove those labels from release-25.05 after branch-off.
Things done
Add a 👍 reaction to pull requests you find important.