Skip to content

gn: 2168 -> 2233 (2024-05-03 -> 2025-04-28)#403859

Merged
emilylange merged 1 commit intoNixOS:stagingfrom
pwaller:gn-bump
Jun 7, 2025
Merged

gn: 2168 -> 2233 (2024-05-03 -> 2025-04-28)#403859
emilylange merged 1 commit intoNixOS:stagingfrom
pwaller:gn-bump

Conversation

@pwaller
Copy link
Contributor

@pwaller pwaller commented May 3, 2025 •
edited
Loading

Tested x86_64-linux, aarch64-linux, pkgsStatic.gn,
pkgsCross.aarch64-multiplatform.gn.

Signed-off-by: Peter Waller [email protected]

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pwaller pwaller changed the base branch from master to staging May 3, 2025 09:55
@pwaller pwaller force-pushed the gn-bump branch 2 times, most recently from aba7bde to 3de9ae0 Compare May 3, 2025 17:51
@github-actions github-actions bot added 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels May 3, 2025
@pwaller pwaller marked this pull request as ready for review May 4, 2025 10:17
@pwaller
Copy link
Contributor Author

pwaller commented Jun 2, 2025

Friendly ping, is this safe to bump?

@emilylange
Copy link
Member

emilylange commented Jun 6, 2025

It appears as if you ran into a package that appears to have 3 inactive maintainers (gn.meta.maintainers).

@networkException and I (chromium.meta.maintainers) only happened to be pinged because of the changes made to the gn overrides in chromium.

From what I can tell, gn is a bit messy in nixpkgs because it is essentially unversioned ("whatever chromium stable uses") and different approaches to version it were tried over the years. This is part of the reason why the package itself has a generic.nix abstraction, but only a single version in package.nix using that nowadays.

If we encounter issues with some gn consumers that can't be patched to work with a newer of gn as part of the next staging cycle, we can always opt to reintroduce this previous version as gn2168 or whatever12.

Can you please update this PR to the latest rev from

nixpkgs/pkgs/applications/networking/browsers/chromium/info.json

Lines 14 to 17 in a5df9ce

"gn": {
"rev": "85cc21e94af590a267c1c7a47020d9b420f8a033",
"hash": "sha256-+nKP2hBUKIqdNfDz1vGggXSdCuttOt0GwyGUQ3Z1ZHI="
},

I will merge this shortly after.

Thanks :)

Footnotes

  1. https://github.com/NixOS/nixpkgs/pull/138359/commits/786b4216c5481d8826c42defabed4721a74e1cd0 ↩

  2. gn1924: drop #353310 ↩

@pwaller
gn: 2168 -> 2233 (2024-05-03 -> 2025-04-28)
1aff0e4 
* Matches commit to chromium info.json https://github.com/NixOS/nixpkgs/blob/a5df9ceb5f057fdbe6f7e7a2a0350c878e34da25/pkgs/applications/networking/browsers/chromium/info.json#L807
* Drops now unneeded patch.
* Use -Wno-format-security.
* Update chromium gn rev path comment to info.json.

Tested x86_64-linux, aarch64-linux, pkgsStatic.gn,
pkgsCross.aarch64-multiplatform.gn.

Signed-off-by: Peter Waller <[email protected]>
@pwaller
Copy link
Contributor Author

pwaller commented Jun 6, 2025

Thanks @emilylange ! Done - I've done my best to make sure the commit message and PR body reflect the new version as well.

@emilylange emilylange changed the title gn: 2168 -> 2223 (2024-05-03 -> 2025-03-21) gn: 2168 -> 2233 (2024-05-03 -> 2025-04-28) Jun 6, 2025
@emilylange emilylange merged commit 2a923be into NixOS:staging Jun 7, 2025
17 of 19 checks passed
This was referenced Jun 22, 2025
Closed
Merged
@marcin-serwin marcin-serwin mentioned this pull request Aug 9, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@networkException networkException Awaiting requested review from networkException

@emilylange emilylange Awaiting requested review from emilylange

@stesie stesie Awaiting requested review from stesie

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@primeos primeos Awaiting requested review from primeos

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pwaller @emilylange