Skip to content

init multiple yuzu forks#403752

Closed
nyanloutre wants to merge 5 commits intoNixOS:masterfrom
nyanloutre:citron-emu-init
Closed

init multiple yuzu forks#403752
nyanloutre wants to merge 5 commits intoNixOS:masterfrom
nyanloutre:citron-emu-init

Conversation

@nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented May 2, 2025 •
edited
Loading

I wanted to support Citron as it is a maintained fork of Yuzu according to the Emulation General Wiki. I tried to mutualize code with torzu as it is very similar.

It still need some work:

  • citron cannot build latest tag because of submodule URL changes (I built latest working commit as a poc)
  • metadata are wrong
  • sudachi submodules needs to all be fixed manually to some reference or maybe we don't support sudachi as the fixes needed to build it are tedious

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 2, 2025
@nyanloutre nyanloutre requested a review from liberodark May 6, 2025 10:12
@nyanloutre nyanloutre force-pushed the citron-emu-init branch 3 times, most recently from 85550a7 to e2fddc9 Compare May 7, 2025 08:47
@nyanloutre nyanloutre changed the title citron-emu: init at 0.6.1 init multiple yuzu forks May 7, 2025
@nyanloutre nyanloutre force-pushed the citron-emu-init branch 6 times, most recently from a679ff6 to d336977 Compare May 12, 2025 09:36
@nyanloutre nyanloutre force-pushed the citron-emu-init branch 2 times, most recently from 5f204fb to 4b360d9 Compare May 12, 2025 09:50
@nyanloutre nyanloutre marked this pull request as ready for review May 12, 2025 09:55
@nyanloutre nyanloutre mentioned this pull request May 12, 2025
Closed
13 tasks
pbsds
pbsds requested changes May 12, 2025
View reviewed changes
Copy link
Member

@pbsds pbsds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering how nintendo has been on a Yuzu DMCA takedown spree of at times 8k+ repos with followups, targeting even unrelated emulators, and even simple frontends, I don't believe yuzu is a good idea to package and distribute in nixpkgs. This is a liability we simply don't want, at least until at least there have been a long-lived steadily-developed fork/rewrite that has survived both publicity and the soon-to-be launch of the switch 2.

I'll mark it as "Request changes" to to hinder merging

I think a flake is a better tool for the job. ;)

@nyanloutre
Copy link
Member Author

nyanloutre commented May 12, 2025

@pbsds so torzu should be removed from nixpkgs ? If not I don't see any reason to block this PR

@pbsds
Copy link
Member

pbsds commented May 12, 2025

I am currently drafting a PR to drop it, which I plan to post on matrix to gather the community consensus. I don't like this either.

@pbsds pbsds mentioned this pull request May 12, 2025
Merged
13 tasks
@nyanloutre
Copy link
Member Author

nyanloutre commented May 12, 2025

For some additional context there is an official maintained yuzu Debian package but I can't find what is their take on the takedown drama.

https://salsa.debian.org/debian/yuzu
https://packages.debian.org/source/sid/yuzu

@liberodark
Copy link
Contributor

liberodark commented May 12, 2025 •
edited
Loading

Hi,

Given the current situation, I don't think any Switch emulators will be tolerated.
Because there's currently a removal request for Torzu, which is very sad. :(
If that is the case I agree with making a flake for use.

Best Regards

@nyanloutre nyanloutre deleted the citron-emu-init branch December 22, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbsds pbsds pbsds requested changes

@liberodark liberodark Awaiting requested review from liberodark

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nyanloutre @pbsds @liberodark