Skip to content

libb2: 0.97 -> 0.98 and fix build on ARM#40362

Merged
dezgeg merged 2 commits intoNixOS:masterfrom
dotlambda:libb2-0.98
May 13, 2018
Merged

libb2: 0.97 -> 0.98 and fix build on ARM#40362
dezgeg merged 2 commits intoNixOS:masterfrom
dotlambda:libb2-0.98

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented May 11, 2018 •
edited
Loading

Motivation for this change

https://hydra.nixos.org/job/nixpkgs/trunk/libb2.aarch64-linux

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @dfoxfranke @dezgeg

@dotlambda dotlambda changed the title Libb2 0.98 libb2: 0.97 -> 0.98 and fix build on ARM May 11, 2018
@dfoxfranke
Copy link
Contributor

dfoxfranke commented May 11, 2018

LGTM.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 11, 2018
@GrahamcOfBorg
Copy link

GrahamcOfBorg commented May 11, 2018

Success on x86_64-linux (full log)

Attempted: libb2

Partial log (click to expand)

make[2]: Leaving directory '/build/libb2-0.98'
make[1]: Leaving directory '/build/libb2-0.98'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rk0n92bvn2dmd8xbf7ydv9rnpvzs4hai-libb2-0.98
shrinking /nix/store/rk0n92bvn2dmd8xbf7ydv9rnpvzs4hai-libb2-0.98/lib/libb2.so.1.0.3
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rk0n92bvn2dmd8xbf7ydv9rnpvzs4hai-libb2-0.98/lib
patching script interpreter paths in /nix/store/rk0n92bvn2dmd8xbf7ydv9rnpvzs4hai-libb2-0.98
checking for references to /build in /nix/store/rk0n92bvn2dmd8xbf7ydv9rnpvzs4hai-libb2-0.98...
/nix/store/rk0n92bvn2dmd8xbf7ydv9rnpvzs4hai-libb2-0.98

@GrahamcOfBorg
Copy link

GrahamcOfBorg commented May 11, 2018

Success on aarch64-linux (full log)

Attempted: libb2

Partial log (click to expand)

make[2]: Leaving directory '/build/libb2-0.98'
make[1]: Leaving directory '/build/libb2-0.98'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9cd2n8jmg94k7s4knx9rd9r236yw9zyc-libb2-0.98
shrinking /nix/store/9cd2n8jmg94k7s4knx9rd9r236yw9zyc-libb2-0.98/lib/libb2.so.1.0.3
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9cd2n8jmg94k7s4knx9rd9r236yw9zyc-libb2-0.98/lib
patching script interpreter paths in /nix/store/9cd2n8jmg94k7s4knx9rd9r236yw9zyc-libb2-0.98
checking for references to /build in /nix/store/9cd2n8jmg94k7s4knx9rd9r236yw9zyc-libb2-0.98...
/nix/store/9cd2n8jmg94k7s4knx9rd9r236yw9zyc-libb2-0.98

@dotlambda
Copy link
Member Author

dotlambda commented May 11, 2018

@dezgeg Please merge if you don't have any objections as you were the one who added --enable-fat.

@dezgeg dezgeg mentioned this pull request May 11, 2018
Closed
@dotlambda
Copy link
Member Author

dotlambda commented May 13, 2018

ping @dezgeg

@dezgeg
Copy link
Contributor

dezgeg commented May 13, 2018

Thank you!

@dezgeg dezgeg merged commit 409b97c into NixOS:master May 13, 2018
@dotlambda dotlambda deleted the libb2-0.98 branch May 13, 2018 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dotlambda @dfoxfranke @GrahamcOfBorg @dezgeg