Skip to content

hheretic: add missing libGL and libGLU depends#403458

Merged
pbsds merged 1 commit intoNixOS:masterfrom
trofi:hheretic-add-missing-deps
May 1, 2025
Merged

hheretic: add missing libGL and libGLU depends#403458
pbsds merged 1 commit intoNixOS:masterfrom
trofi:hheretic-add-missing-deps

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented May 1, 2025

Without the change the build fails as https://hydra.nixos.org/build/294989234:

checking for OpenGL support... no
configure: error: *** OpenGL not found!

ZHF: #403336

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Without the change the build fails as https://hydra.nixos.org/build/294989234:

    checking for OpenGL support... no
    configure: error: *** OpenGL not found!

ZHF: NixOS#403336
@trofi
Copy link
Contributor Author

trofi commented May 1, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 403458


x86_64-linux

✅ 1 package built:
  • hheretic

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 1, 2025
@nix-owners nix-owners bot requested a review from majiru May 1, 2025 21:35
@trofi trofi mentioned this pull request May 1, 2025
13 tasks
@pbsds
Copy link
Member

pbsds commented May 1, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 403458


x86_64-linux

✅ 1 package built:
  • hheretic

aarch64-linux

✅ 1 package built:
  • hheretic

x86_64-darwin

⏩ 1 package marked as broken and skipped:
  • hheretic

aarch64-darwin

⏩ 1 package marked as broken and skipped:
  • hheretic

@pbsds pbsds merged commit a3214c5 into NixOS:master May 1, 2025
39 of 43 checks passed
@trofi trofi deleted the hheretic-add-missing-deps branch May 1, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants