Skip to content

haskellPackages: misc fixes#403419

Merged
wolfgangwalther merged 2 commits intoNixOS:haskell-updatesfrom
sternenseemann:haskell-misc
May 2, 2025
Merged

haskellPackages: misc fixes#403419
wolfgangwalther merged 2 commits intoNixOS:haskell-updatesfrom
sternenseemann:haskell-misc

Conversation

@sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented May 1, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label May 1, 2025
@nix-owners nix-owners bot requested review from maralorn and wolfgangwalther May 1, 2025 19:53
@github-actions github-actions bot added 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels May 1, 2025
@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented May 1, 2025

I'm confused about why this causes so many rebuilds, apparently.

@sternenseemann
Copy link
Member Author

sternenseemann commented May 1, 2025

tls -> serialise -> cborg, unfortunately. Maybe we should hold that back for the next iteration.

@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented May 1, 2025

It probably doesn't make a difference in terms of whether we will hit next staging-next or not. Even if we rebuild now, we'd still make that, right?

But yeah, the question is whether the removal of a doJailbreak is worth that many rebuilds - maybe put that together with something else that comes up.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels May 1, 2025
@sternenseemann
Copy link
Member Author

sternenseemann commented May 1, 2025

It probably doesn't make a difference in terms of whether we will hit next staging-next or not. Even if we rebuild now, we'd still make that, right?

It's annoying for finishing this rotation, it's basically done, so a full rebuild just delays things by half a week or more

@wolfgangwalther wolfgangwalther merged commit 273b559 into NixOS:haskell-updates May 2, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther Awaiting requested review from wolfgangwalther

@maralorn maralorn Awaiting requested review from maralorn

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sternenseemann @wolfgangwalther