Skip to content

python3Packages.fitparse: init at 1.2.0; garmin-grafana: init at 0.3.0#403107

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
aciceri:garmin-grafana
Dec 8, 2025
Merged

python3Packages.fitparse: init at 1.2.0; garmin-grafana: init at 0.3.0#403107
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
aciceri:garmin-grafana

Conversation

@aciceri
Copy link
Member

@aciceri aciceri commented Apr 30, 2025

Things done

Adding garmin-grafana and fitparse, a dependency which was missing from nixpkgs.
Apparently influxdb3-python (already pacakged in nixpkgs) depends on pyarrow which is built without ORC, there is already an issue years old. I've tried enabling ORC in pyarrow without luck and at the end I chose to download pyarrow as prebuilt wheel, it's not optimal but it seems to work well.

I'm leaving this as a draft for a few days until the version 0.1.0 is out (a few days according to the author). As soon as it's released I'll change the rev and mark it as ready.

I've tried running this both on x86_64-linux and aarch64-linux.

cc @arpanghosh8453

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 30, 2025
@arpanghosh8453
Copy link

@aciceri The version v0.1.0 is now live. Thank you.

@aciceri
Copy link
Member Author

aciceri commented May 1, 2025

Thank you! I also just added the dashboard's JSON file to the derivatin's passthru attribute, this way it can be directly referenced when using services.grafana.provision.dashboards.settings.providers.*.options.path.

I'm marking it as ready now.

@aciceri aciceri marked this pull request as ready for review May 1, 2025 09:18
@nix-owners nix-owners bot requested a review from natsukium May 1, 2025 09:19
@ethancedwards8
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 403107


aarch64-darwin

✅ 4 packages built:
  • python312Packages.fitparse
  • python312Packages.fitparse.dist
  • python313Packages.fitparse
  • python313Packages.fitparse.dist

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 1, 2025
Copy link
Contributor

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried enabling ORC in pyarrow without luck and at the end I chose to download pyarrow as prebuilt wheel, it's not optimal but it seems to work well.

Reading this, I tried that, and I think I got it: #405543

@aciceri aciceri mentioned this pull request May 10, 2025
13 tasks
@aciceri
Copy link
Member Author

aciceri commented May 10, 2025

Reading this, I tried that, and I think I got it: #405543

Great job! I've tried using your pyarrow from your PR and it works great.
I will keep this PR as "ready to merge", if your PR gets merged before I'll modify this one otherwise I'll open another as soon as yours is merged.

@aciceri aciceri changed the title python3Packages.fitparse: init at 1.2.0; garmin-grafana: init at 0.1.0 python3Packages.fitparse: init at 1.2.0; garmin-grafana: init at 0.2.0 May 10, 2025
@aciceri
Copy link
Member Author

aciceri commented May 10, 2025

Just updated to the new 0.2.0 version

@aciceri aciceri changed the title python3Packages.fitparse: init at 1.2.0; garmin-grafana: init at 0.2.0 python3Packages.fitparse: init at 1.2.0; garmin-grafana: init at 0.3.0 Sep 7, 2025
@aciceri
Copy link
Member Author

aciceri commented Sep 7, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 403107
Commit: 1962f9ec4f13bd1aeb4ecd5db08a2af87179d1f0 (subsequent changes)
Merge: f6fe58f56bda28a564d98f387d516d323f4b554d

Logs: https://github.com/aciceri/nixpkgs-review-gha/actions/runs/17528937282


x86_64-linux

✅ 6 packages built:
  • garmin-grafana
  • garmin-grafana.dist
  • python312Packages.fitparse
  • python312Packages.fitparse.dist
  • python313Packages.fitparse
  • python313Packages.fitparse.dist

aarch64-linux

✅ 6 packages built:
  • garmin-grafana
  • garmin-grafana.dist
  • python312Packages.fitparse
  • python312Packages.fitparse.dist
  • python313Packages.fitparse
  • python313Packages.fitparse.dist

x86_64-darwin (sandbox = true)

✅ 4 packages built:
  • python312Packages.fitparse
  • python312Packages.fitparse.dist
  • python313Packages.fitparse
  • python313Packages.fitparse.dist

aarch64-darwin (sandbox = true)

✅ 4 packages built:
  • python312Packages.fitparse
  • python312Packages.fitparse.dist
  • python313Packages.fitparse
  • python313Packages.fitparse.dist

@aciceri
Copy link
Member Author

aciceri commented Dec 5, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 403107
Commit: f179b6d645a0b25ecec3a175b8ce086d54b6f59b


x86_64-linux

✅ 6 packages built:
  • garmin-grafana
  • garmin-grafana.dist
  • python312Packages.fitparse
  • python312Packages.fitparse.dist
  • python313Packages.fitparse
  • python313Packages.fitparse.dist

aarch64-linux

✅ 6 packages built:
  • garmin-grafana
  • garmin-grafana.dist
  • python312Packages.fitparse
  • python312Packages.fitparse.dist
  • python313Packages.fitparse
  • python313Packages.fitparse.dist

x86_64-darwin

✅ 4 packages built:
  • python312Packages.fitparse
  • python312Packages.fitparse.dist
  • python313Packages.fitparse
  • python313Packages.fitparse.dist

aarch64-darwin

✅ 4 packages built:
  • python312Packages.fitparse
  • python312Packages.fitparse.dist
  • python313Packages.fitparse
  • python313Packages.fitparse.dist

@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Dec 8, 2025
Merged via the queue into NixOS:master with commit 0c24290 Dec 8, 2025
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants