I would rather we add this an optional separate version, like the others, until we know that changing the default TBB won't cause breakage elsewhere. This seems to have been an issue a few times and I'm not sure of a good policy for how to decide when to change it globally. @Ericson2314 any thoughts about this?

Note that changing this version would also cause tbb_2021_11, which is a top-level alias that many other packages reference directly, to install this version tbb_2021_13:

https://github.com/Saterfield990/nixpkgs/blob/a7f8900f6f8ecbfc36d0543d945a64693a77b075/pkgs/top-level/all-packages.nix#L6105

So I think the best thing to do here is to keep the default.nix here as-is, then add 2021_13.nix under the tbb/ dir as a new version. Then add a new top-level alias for it in the same spot that I link to.

Can you make that change @Saterfield990?

Then either in a separate commit or PR we can update all existing packages that reference tbb_2021_11 to use tbb_2021_13, and if there is breakage found, at least those dependent packages can roll back to _11.

I believe these patches are still needed with this version (from last year) to fix the MinGW builds. You can try cross-compiling for MinGW to double check but pretty sure we want to keep these. They were added to the definition here recently, I think after this PR was originally submitted.

I just tried building this locally for MinGW and it seems to work without these patches. Also looking upstream it appears they have been applied. So I think it's safe to keep these removed after all.

It does not build with those patches since it complains they were applied already.

This one it looks like we don't need with this version though:

https://github.com/uxlfoundation/oneTBB/blob/1c4c93fc5398c4a1acb3492c02db4699f3048dea/CMakeLists.txt#L271-L274