xwax: fix the build (missing alsa-lib input)#402378
Merged
pbsds merged 2 commits intoNixOS:masterfrom May 10, 2025
Merged
Conversation
Without the change the build fails as https://hydra.nixos.org/build/294945388: alsa.c:24:10: fatal error: alsa/asoundlib.h: No such file or directory 24 | #include <alsa/asoundlib.h> | ^~~~~~~~~~~~~~~~~~
github-actions
bot
added
10.rebuild-darwin: 0
Sigmanificient
approved these changes
Apr 28, 2025
wegank
added
the
12.approvals: 1
Member
|
Upon further testing on a similar fix pr (xwax: add missing dependency, unbreak), I found some issue with the current state of the derivation: The apps opens but and connect to my Startup logs: |
Sigmanificient
removed
the
12.approvals: 1
13 tasks
Contributor
Author
|
I'm not familiar with the program. But I think the trick is to make the scanner and importers to work:
If I use |
13 tasks
Member
|
Is it possible to add those shebang amendments to the derivation? |
Contributor
Author
|
Currently the derivation does not install them. Should it? I was not sure if the users are expected to provide their own equivalent importers. |
Member
|
Ah, okay. Then help me understand, is the issue @Sigmanificient uncovered just a pre-existing wart with the package or is it a regression? |
Contributor
Author
|
I think it's pre-existing. |
Contributor
Author
|
Proposed the default installation of importers as: |
trofi
added a commit
to trofi/nixpkgs
that referenced
this pull request
May 10, 2025
Without the change user needs to supply their own importer and scanner. Discovered in NixOS#402378 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the change the build fails as
https://hydra.nixos.org/build/294945388:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.