bombono: pin to boost183 to fix the build#402340
Merged
bjornfor merged 1 commit intoNixOS:masterfrom Apr 28, 2025
Merged
Conversation
Without the change `bombono` build fails on `master` as https://hydra.nixos.org/build/294719057: In file included from src/mbase/project/_extlibs_.h:61, from src/mgui/_extlibs_.h:31, from src/mgui/_pc_.h:29, from src/mgui/dialog.cpp:22: src/mlib/sdk/bfs.h:12:10: fatal error: boost/filesystem/convenience.hpp: No such file or directory 12 | #include <boost/filesystem/convenience.hpp> // fs::create_directories() | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
trofi
changed the title
This was referenced Apr 27, 2025
github-actions
bot
added
10.rebuild-darwin: 0
bjornfor
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the change
bombonobuild fails onmasteras https://hydra.nixos.org/build/294719057:Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.