workflows/labels: skip for staging-next / haskell-updates / python-updates#402332
Conversation
github-actions
bot
added
6.topic: continuous integration
nix-owners
bot
requested review from
LeSuisse,
Mic92,
azuwis,
infinisil,
mweinelt,
risicle and
zowoq
github-actions
bot
added
10.rebuild-darwin: 0
|
This means we loose the python label on python-updates and the haskell one on haskell-updates, though? We should probably figure out whether we can preserve them. |
Makes sense. Maybe we can add a "staging" label as well, which can be used to find staging-next / staging-xx.yy-next PRs quickly. Using |
wolfgangwalther
force-pushed
the
ci-no-label-staging-next
branch
from
00cb10d to
b22f888
Compare
|
I made some changes to keep the haskell/python topic labels for those branches. I also propose to add the following entirely new labels:
Feedback welcome! |
wolfgangwalther
force-pushed
the
ci-no-label-staging-next
branch
from
b22f888 to
68f1801
Compare
wegank
added
12.approved-by: package-maintainer
…dates Labelling those PRs is more annoying then useful.
This adds some labels related to the higher level workflows of developing nixpkgs: - "4.workflow: backport" can be used to filter everything targeting the stable branches, both release-XX.YY or staging-XX.YY. - "4.workflow: package set updates" can be used to filter the haskell/python package set PRs. Can be combined with "6.topic: haskell" or "6.topic: python". - "4.workflow: staging" can be used to filter for all staging-next PRs, both to master and release branches.
wolfgangwalther
force-pushed
the
ci-no-label-staging-next
branch
from
68f1801 to
5ed0205
Compare
|
I created the labels, let's see how it goes. |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-402332-to-release-24.11 origin/release-24.11
cd .worktree/backport-402332-to-release-24.11
git switch --create backport-402332-to-release-24.11
git cherry-pick -x 19095200155c0164eeb1629d3ad5f2a53ad40e15 5ed0205f6a9f6b1939c5b9caf835c368b578fb62 |
|
Backport in #404107. |
|
Seems like this didn't work, yet. Workflow run after the merge into staging-next: https://github.com/NixOS/nixpkgs/actions/runs/14821411700/job/41608868160?pr=401526 The first two steps are running, but not the third. |
Introduced in NixOS#402332, but head.repo is an object, not a string.
wolfgangwalther
added
the
2.status: needs-changes
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-402332-to-release-24.11 origin/release-24.11
cd .worktree/backport-402332-to-release-24.11
git switch --create backport-402332-to-release-24.11
git cherry-pick -x 19095200155c0164eeb1629d3ad5f2a53ad40e15 5ed0205f6a9f6b1939c5b9caf835c368b578fb62 |
Introduced in NixOS#402332, but head.repo is an object, not a string.
Introduced in NixOS#402332, but broken on all ends: - pull_request needs to be event.pull_request - pull_request.head is an object, not a string - github.ref_protected is about the target branch, because this runs as a pull_request_target event Thus, we need to list the branches manually.
Introduced in NixOS#402332, but broken on all ends: - pull_request needs to be event.pull_request - pull_request.head is an object, not a string - github.ref_protected is about the target branch, because this runs as a pull_request_target event Thus, we need to list the branches manually. (cherry picked from commit e676235)
|
I have added workflow staging / workflow package set update labels to the already closed PRs from the 24.11 cycle retroactively. Thus, it's possible to filter those easily now. |
4 participants
Labeling those PRs is more annoying then useful.
Things done
(not tested, yet)
Add a 👍 reaction to pull requests you find important.