Skip to content

staging-next 2025-04-24#401526

Merged
vcunat merged 1170 commits intomasterfrom
staging-next
May 5, 2025
Merged

staging-next 2025-04-24#401526
vcunat merged 1170 commits intomasterfrom
staging-next

Conversation

khaneliman and others added 30 commits April 21, 2025 14:07
Currently if the credential helpers packaged with git aren't on your PATH, git will fail to locate them. This most notably affects git maintanence1 which generates systemd units / launchd agents that invoke git directly without setting PATH. Home Manager is also able to generate maintanence units for systemd and does not set PATH2, meaning credential helpers will not work without additional configuration.

Moving the credential helpers to git's exec path3 allows git to locate them regardless of how PATH is set, and matches the packaging of Fedora4 and Homebrew5. Typically credential helpers are not added to PATH unless they are provided by another package separate from git (e.g. git-credential-gcloud).

I opted to create symlinks at the old bin paths in case some users were relying on invoking them directly. In practice I doubt this is done much. If we want to slim down git's bin dir I think the symlinks could be removed, and in doing so we'd better match the packaging done in other distributions.
This was removed by upstream in
<renpy/renpy@f2d3e0d>.
This isn’t used by the X11 backend anyway, which is the only one
we build for macOS. Even though it has a native macOS frontend. But
I don’t want to spend more time on this.
Patch needs adjusting, build process is super messed up, package
is out of date and not used in Nixpkgs other than by another unused
library… not worth it.
The dependency is added correctly now since ghc-tags 1.5 and GHC 9.8
don't match, causing Cabal to resolve the flag as we'd like here.
Not very important anymore and no longer works with the core pkg version
of time shipped with >= 9.12.
The next version(s) of brillo* won't need these overrides as the
dependency on bytestring has been removed in the upstream repository.
Test suites won't work correctly (or entirely) since some test data is
missing from the released tarballs.
@wolfgangwalther wolfgangwalther removed 6.topic: printing Drivers, CUPS & Co. 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: vim Advanced text editor 6.topic: erlang General-purpose, concurrent, functional high-level programming language 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: stdenv Standard environment 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: R R is a programming language for statistical computing and data visualization. 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 6.topic: lib The Nixpkgs function library 6.topic: games Gaming on NixOS 6.topic: php PHP is a general-purpose scripting language geared towards web development. 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: dotnet Language: .NET 6.topic: tcl Dynamic, multi-paradigm programming language 6.topic: teams Relating to team creation, updates, other management actions labels May 4, 2025
@vcunat vcunat merged commit a9245b8 into master May 5, 2025
28 of 29 checks passed
@github-project-automation github-project-automation bot moved this to Done in Stdenv May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 4.workflow: staging A staging-next or staging-next-XX.YY branch 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.