Skip to content

nodejs: use more shared libs#401454

Merged
aduh95 merged 1 commit intoNixOS:stagingfrom
aduh95:nodejs-shared-libs
Jan 11, 2026
Merged

nodejs: use more shared libs#401454
aduh95 merged 1 commit intoNixOS:stagingfrom
aduh95:nodejs-shared-libs

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 24, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment label Apr 24, 2025
@aduh95 aduh95 added 2.status: wait for branch‐off Waiting for the next Nixpkgs branch‐off 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment and removed 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment labels Apr 24, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Apr 24, 2025
@aduh95 aduh95 force-pushed the nodejs-shared-libs branch 2 times, most recently from 115c810 to 9cc05c2 Compare April 26, 2025 09:58
@aduh95 aduh95 marked this pull request as ready for review May 8, 2025 09:40
@aduh95 aduh95 force-pushed the nodejs-shared-libs branch 2 times, most recently from dd708d3 to d314eb4 Compare May 8, 2025 09:46
@nix-owners nix-owners bot requested a review from NickCao May 8, 2025 09:49
@aduh95 aduh95 marked this pull request as draft May 8, 2025 15:24
@aduh95 aduh95 mentioned this pull request May 10, 2025
Merged
13 tasks
@aduh95 aduh95 force-pushed the nodejs-shared-libs branch from d314eb4 to 9fcfc04 Compare May 28, 2025 15:53
@github-actions github-actions bot added 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. and removed 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels May 28, 2025
@aduh95 aduh95 force-pushed the nodejs-shared-libs branch 2 times, most recently from a190f6a to 36c8ebb Compare May 28, 2025 19:33
@FliegendeWurst FliegendeWurst removed the 2.status: wait for branch‐off Waiting for the next Nixpkgs branch‐off label May 29, 2025
FliegendeWurst
FliegendeWurst reviewed May 29, 2025
View reviewed changes
@aduh95 aduh95 force-pushed the nodejs-shared-libs branch from 36c8ebb to 385e2ce Compare May 29, 2025 19:45
@github-actions github-actions bot added 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels May 29, 2025
@aduh95 aduh95 force-pushed the nodejs-shared-libs branch from 385e2ce to eefb87b Compare June 6, 2025 23:33
@github-actions github-actions bot added 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. and removed 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Jun 6, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 9, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 28, 2025
@aduh95 aduh95 mentioned this pull request Sep 4, 2025
Merged
13 tasks
@aduh95 aduh95 force-pushed the nodejs-shared-libs branch from 9a4f2d0 to b831505 Compare September 5, 2025 08:51
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. and removed 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. labels Sep 5, 2025
@aduh95 aduh95 force-pushed the nodejs-shared-libs branch from b831505 to 527384b Compare September 8, 2025 13:40
@aduh95 aduh95 requested review from Conni2461 and removed request for NickCao September 8, 2025 13:41
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 13, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 13, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 3, 2025
@aduh95 aduh95 closed this Oct 13, 2025
@aduh95 aduh95 force-pushed the nodejs-shared-libs branch from 9325287 to f5c2101 Compare October 13, 2025 21:43
@aduh95 aduh95 reopened this Oct 13, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 13, 2025
@Sigmanificient Sigmanificient mentioned this pull request Oct 17, 2025
Merged
13 tasks
@aduh95 aduh95 force-pushed the nodejs-shared-libs branch from d6cc025 to 8d4b117 Compare December 28, 2025 00:08
@aduh95 aduh95 mentioned this pull request Jan 4, 2026
Merged
13 tasks
@aduh95 aduh95 force-pushed the nodejs-shared-libs branch from 8d4b117 to 72e8273 Compare January 7, 2026 19:53
@aduh95 aduh95 force-pushed the nodejs-shared-libs branch from 72e8273 to 7d59736 Compare January 7, 2026 19:56
@aduh95
Copy link
Contributor Author

aduh95 commented Jan 7, 2026

@ofborg build nodejs_20.passthru.tests nodejs_22.passthru.tests nodejs_24.passthru.tests nodejs_25.passthru.tests

@aduh95 aduh95 added this pull request to the merge queue Jan 11, 2026
Merged via the queue into NixOS:staging with commit fa8117b Jan 11, 2026
30 of 34 checks passed
@aduh95 aduh95 deleted the nodejs-shared-libs branch January 11, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst left review comments

@Conni2461 Conni2461 Awaiting requested review from Conni2461

Assignees

No one assigned

Labels

6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aduh95 @FliegendeWurst