Revert "pkgs/top-level/stage.nix: add pkgsLLVMLibc"#401317
Revert "pkgs/top-level/stage.nix: add pkgsLLVMLibc"#401317emilazy merged 1 commit intoNixOS:masterfrom
Conversation
This reverts commit 41b1402.
nix-owners
bot
requested review from
Artturin,
Ericson2314,
alyssais,
emilazy,
philiptaron and
reckenrode
RossComputerGuy
left a comment
RossComputerGuy
left a comment
There was a problem hiding this comment.
This shouldn't be a full revert of the commit but only drop pkgsLLVMLibc. We probably could just comment out the pkgsLLVMLibc and leave a comment explaining why it's commented out.
If this is how you want to handle it please open another PR. |
github-actions
bot
added
10.rebuild-darwin: 1
|
Merging since the issue has been present since January, the fix in #375330 seems complicated to verify, and it doesn’t make sense to ship something broken in 25.05. Can always revert the revert if a more targeted adjustment is PR’d. |
Only requires eval, shouldn't be too complicated. I am hoping the fix gets approved soon. |
|
I mean verify for correctness wrt LLVM – it’s unclear to me why we want to override |
|
Gotcha, I tested a build and it worked fine so it's not like nothing broke because of it. |
3 participants
This reverts commit 41b1402.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.