Conversation
cfd9267 to
fdec92d
Compare
|
|
|
I tried listing dbus services in a gnome VM with:
|
fdec92d to
6c1dfd3
Compare
|
There was a problem hiding this comment.
All three components have Requires: gupnp-1.2 >= 1.2.0, glib-2.0 >= 2.28 in the pkg-config files. So they should be still propagated.
There was a problem hiding this comment.
Wait why would this need to propagate? previously, -core propagated because it was needed for renderer/server. However, now that it is all combined and built all at once, i don't see the need for the propagation anymore
There was a problem hiding this comment.
All dependencies transitively listed in Requires field of a .pc file need to be on PKG_CONFIG_PATH or for the dependency defined by that .pc file to be found.
We typically add them to propagatedBuildInputs so that we do not need to add those transitive dependencies to buildInputs each dependent of the .pc file.
Though it looks like there are no dependents for the dleyna .pc files so perhaps the point is moot:
https://codesearch.debian.net/search?q=dleyna-core-1.0&literal=1
https://codesearch.debian.net/search?q=dleyna-renderer-service-1.0&literal=1
https://codesearch.debian.net/search?q=dleyna-server-service-1.0&literal=1
There was a problem hiding this comment.
Currently there is not even a .pc file being installed - is that a problem?
There was a problem hiding this comment.
I tried testing it but so far I did not even manage to make it work in other applications.
- I set up minidlnad (with videos, audio and pictures) on my router and verified that it works on VLC on Android.
- Opened firewall ports on my desktop, not sure if necessary or complete:
sudo nixos-firewall-tool open tcp 2869andsudo nixos-firewall-tool open udp 1900 - In VLC on Desktop, open View » Playlist, check that the server is listed in Universal Plug'n'Play: The tab is empty
-
${gupnp-tools}/bin/gssdp-discover --interface=wlp3s0does not show any available messages. - Kill running dleyna processes if present, run
${dleyna}/libexec/dleyna-renderer-serviceto let the new version bind to D-Bus address. - Add
grilo-pluginstobuildInputsofrhythmbox, enable "Grilo media browser" plug-in: Nothing listed - In GNOME Music, nothing listed.
- In GNOME Photos nothing is listed.
- In Totem, I get ton of
grl_source_resolve: assertion 'GRL_IS_SOURCE (source)' failedcriticals but same on master. -
${gssdp-tools}/bin/gssdp-device-sniffer --interface=wlp3s0does not show anything.
There was a problem hiding this comment.
Uh oh - I was happy to see it listed in journal, but seems i have some work to do!
There was a problem hiding this comment.
I just wanted to check that it still works (I last tested it ages ago) but did not even get it to work on nixos-unstable. The whole DLNA/UPNP ecosystem has always been extremely flaky in my experience (slow ARM devices taking tens of seconds for every request, often timing out or otherwise failing because the implementation is broken).
I just gotten VLC on my desktop PC to discover the DLNA server and play the files once but after restarting VLC, I cannot get it to work again.
So I would probably not spend too much time on it. Especially when of the four apps (Totem, GNOME Photos, GNOME Music currently filtered out, Rhythmbox), only the last one is somewhat maintained and the package does not even include the necessary grilo-plugins.
Edit: There is also pragha but there, the grilo-plugins are disabled by default.
|
Currently working on fixing up #400430, then i'll take a look here. Thanks for the detailed review though :) |
6c1dfd3 to
84921fe
Compare
84921fe to
e3aa1e0
Compare

dleynamoved from github to https://gitlab.gnome.org/World/dLeyna.Most importantly, the project has been unified into one repository and one meson build. This means the package no longer needs to be split apart. Similar is valid for the dbus service and therefore nixos modules.
To not break things that depend on dleyna outside nixpkgs, i added aliases to the old (split) names, these all point to the same (unified) dleyna package.
Closes #399076
Part of #360897
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.