equicord: 1.11.4 -> 2025-04-23#400097
Merged
niklaskorz merged 1 commit intoNixOS:masterfrom Apr 23, 2025
Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 0
NotAShelf
force-pushed
the
bump-equicord
branch
2 times, most recently
from
8a0506f to
d9fabed
Compare
niklaskorz
reviewed
Apr 23, 2025
Member
There was a problem hiding this comment.
For the commit message and PR title I'd prefer the usual equicord: 1.11.4 -> 2025-04-23. The description and comments already describe the reason for the new versioning scheme.
We should probably also change the updateScript to ensure it only picks up versions with this scheme, i.e.:
passthru.updateScript = nix-update-script {
extraArgs = [
"--version-regex"
"^\d{4}-\d{2}-\d{2}$"
];
};
Member
Author
|
Dates are just incrementing strings, no? I would assume nix-update-script is able to catch yyyy-mm-dd since it just goes up. |
Member
Is upstream guaranteed to not push a new |
Member
Author
|
I would hope so... |
NotAShelf
force-pushed
the
bump-equicord
branch
from
d9fabed to
20d875f
Compare
Member
|
niklaskorz
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream has began tagging by date, we update Equicord here and switch to the new tag to remain up to date.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.