Merged
Conversation
litebrowser no longer depends on poco.
The Poco Foundation CMake config file unconditionally searches for utf8proc. Therefore, every package that uses this CMake config requires utf8proc. Remove all utf8proc dependencies that were manually added because utf8proc was not propagated.
13 tasks
github-actions
bot
added
10.rebuild-darwin: 1-10
nix-owners
bot
requested review from
Lilacious,
felixsinger,
fgaz and
tomodachi94
wegank
added
12.approvals: 1
dwt
approved these changes
Apr 17, 2025
Contributor
dwt
left a comment
dwt
left a comment
There was a problem hiding this comment.
I was wondering back then if this was sensible, and the fact that litebrowser doesn't depend on poco anymore is something I definitely didn't see.
Thanks!
Member
|
@NixOS/nixpkgs-merge-bot merge |
Contributor
|
@felixsinger merge not permitted (#305350): |
wegank
added
12.approvals: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
Packages that depend on Poco Foundation using CMake always require utf8proc to be available. See: #383163 (comment)
Also, remove litebrowser's dependency on Poco, as this dependency was removed upstream.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.
cc @dwt