nixos/tests/gitlab: adjust test for ssh-root-provision#398846
Closed
sternenseemann wants to merge 1 commit intoNixOS:masterfrom
Closed
nixos/tests/gitlab: adjust test for ssh-root-provision#398846sternenseemann wants to merge 1 commit intoNixOS:masterfrom
sternenseemann wants to merge 1 commit intoNixOS:masterfrom
Conversation
The sshd nixos module now creates /root/.ssh via systemd-tmpfiles, so manually creating it with mkdir without -p will fail. Unfortunately, the test still fails due to an unrelated issue which seems to be an instance of https://gitlab.com/gitlab-org/gitlab/-/issues/434331 from a cursory look. I am having trouble figuring this out since I don't know anything about GitLab.
github-actions
bot
added
the
6.topic: nixos
13 tasks
github-actions
bot
added
10.rebuild-darwin: 0
This was referenced Apr 15, 2025
Member
Author
|
@ofborg test gitlab |
drupol
added
the
2.status: merge conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sshd nixos module now creates /root/.ssh via systemd-tmpfiles, so manually creating it with mkdir without -p will fail.
Unfortunately, the test still fails due to an unrelated issue which seems to be an instance of
https://gitlab.com/gitlab-org/gitlab/-/issues/434331 from a cursory look. I am having trouble figuring this out since I don't know anything about GitLab.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.