Skip to content

nixosTests.gitlab: fix#398837

Merged
vcunat merged 1 commit intoNixOS:masterfrom
wolfgangwalther:gitlab-test
Apr 15, 2025
Merged

nixosTests.gitlab: fix#398837
vcunat merged 1 commit intoNixOS:masterfrom
wolfgangwalther:gitlab-test

Conversation

@wolfgangwalther
Copy link
Contributor

Not sure why the .ssh folder already exists by now, but this fixes it for now and makes sure it won't regress if the folder does not exist anymore.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Not sure why the .ssh folder already exists by now, but this fixes it
for now and makes sure it won't regress if the folder does not exist
anymore.
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Apr 15, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 15, 2025
@vcunat vcunat added the 1.severity: channel blocker Blocks a channel label Apr 15, 2025
@sternenseemann
Copy link
Member

The mkdir is completely unnecessary now I think: #372979 (#398846)

@vcunat vcunat merged commit 52fa4ab into NixOS:master Apr 15, 2025
23 checks passed
@vcunat
Copy link
Member

vcunat commented Apr 15, 2025

I don't know. Let's unblock and you (anyone) can tweak this later. The same change and this PR is also in #398548

I checked that the test works for me now.

@wolfgangwalther wolfgangwalther deleted the gitlab-test branch April 15, 2025 13:02
@yayayayaka
Copy link
Member

Yeah I added a -p in 95ab730 but it got dropped with a force-push by accident.

@vcunat
Copy link
Member

vcunat commented Apr 16, 2025

I believe that was dropped intentionally because rebasing past this pull request. (i.e. your commit would get an empty diff)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: channel blocker Blocks a channel 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants