Skip to content

gitlab: 17.10.1 -> 17.10.4#398548

Merged
leona-ya merged 2 commits intoNixOS:masterfrom
leona-ya:push-uxrtkmuzwtrv
Apr 15, 2025
Merged

gitlab: 17.10.1 -> 17.10.4#398548
leona-ya merged 2 commits intoNixOS:masterfrom
leona-ya:push-uxrtkmuzwtrv

Conversation

@leona-ya
Copy link
Member

@leona-ya leona-ya commented Apr 14, 2025

https://about.gitlab.com/releases/2025/04/09/patch-release-gitlab-17-10-4-released/
https://about.gitlab.com/releases/2025/04/02/gitlab-17-10-3-released/

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@leona-ya leona-ya added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Apr 14, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 14, 2025
@nix-owners nix-owners bot requested review from globin, krav, talyz and yayayayaka April 14, 2025 11:58
@yayayayaka
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 398548


x86_64-linux

✅ 5 packages built:
  • gitaly
  • gitlab
  • gitlab-ee
  • gitlab-pages
  • gitlab-workhorse

Copy link
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed another commit to fix the nixos test. Looking good to me, thanks! ❤️

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Apr 14, 2025
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Apr 15, 2025
@vcunat vcunat mentioned this pull request Apr 15, 2025
5 tasks
@leona-ya leona-ya force-pushed the push-uxrtkmuzwtrv branch from 95ab730 to 1e28b01 Compare April 15, 2025 13:00
@github-actions github-actions bot removed the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Apr 15, 2025
@leona-ya
Copy link
Member Author

nixos test works on x86_64-linux, aarch64-linux and tested manually on my instance.

@leona-ya leona-ya merged commit 3f992f3 into NixOS:master Apr 15, 2025
22 checks passed
@leona-ya leona-ya deleted the push-uxrtkmuzwtrv branch April 15, 2025 14:18
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Apr 15, 2025

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants