nixos/emacs: make systemd report clean exit status when stopping#397916
Merged
wegank merged 1 commit intoNixOS:masterfrom Apr 23, 2025
Merged
nixos/emacs: make systemd report clean exit status when stopping#397916wegank merged 1 commit intoNixOS:masterfrom
wegank merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: nixos
panchoh
approved these changes
Apr 16, 2025
wegank
added
the
12.approvals: 1
AndersonTorres
approved these changes
Apr 18, 2025
wegank
added
12.approvals: 2
jian-lin
approved these changes
Apr 20, 2025
Contributor
jian-lin
left a comment
jian-lin
left a comment
There was a problem hiding this comment.
LGTM, thanks!
To avoid future divergence between upstream systemd service and our NixOS module, it would be good to use upstream systemd service (with necessary modifications such as ExecStart) through systemd.packages = [ pkgs.emacs ]; instead of duplicating the upstream service.
wegank
added
12.approvals: 3+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://debbugs.gnu.org/cgi/bugreport.cgi?bug=45181 for details
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.