Skip to content

nodejs: skip tests that are failing on macOS 15.4#397172

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
aduh95:nodejs-macos-skip-tests
Apr 13, 2025
Merged

nodejs: skip tests that are failing on macOS 15.4#397172
vcunat merged 1 commit intoNixOS:staging-nextfrom
aduh95:nodejs-macos-skip-tests

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 8, 2025

The following tests are failing for me since the 15.4 macOS update.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment label Apr 8, 2025
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 8, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 8, 2025
@aduh95 aduh95 requested a review from emilazy April 9, 2025 13:31
@vcunat vcunat merged commit 2e57d9e into NixOS:staging-next Apr 13, 2025
27 of 28 checks passed
@aduh95 aduh95 deleted the nodejs-macos-skip-tests branch April 13, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants