Skip to content

gitlab-runner: 17.2.0 -> 17.10.1#396939

Merged
leona-ya merged 1 commit intoNixOS:masterfrom
commiterate:update/gitlab-runner
Apr 8, 2025
Merged

gitlab-runner: 17.2.0 -> 17.10.1#396939
leona-ya merged 1 commit intoNixOS:masterfrom
commiterate:update/gitlab-runner

Conversation

@commiterate
Copy link
Contributor

@commiterate commiterate commented Apr 7, 2025

Things done

Update GitLab Runner from 17.2.0 to 17.10.1.

I'm not sure what the rationale is for the ongoing switch attempt from the buildGoModules default phases to upstream Make targets (#392089), but I assume there was some upstream change that appeared to make buildGoModule harder to use. The upstream Make files have a lot of questionable assumptions and impurities, so opting to stay with buildGoModules default phases here.

Note that this also removes all of the upstream helper binaries that are only intended to be used in their Make targets (e.g. check-test-directives, pull-images-for-tests, update-feature-flags-docs).

/nix/store/hcp299vrzf484psknyz5l07j42wqrfv8-gitlab-runner-17.10.1
└── bin
    ├── clear-docker-cache
    ├── gitlab-runner
    └── gitlab-runner-helper
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 7, 2025
@commiterate commiterate mentioned this pull request Apr 8, 2025
13 tasks
Copy link
Member

@leona-ya leona-ya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my instance. Thank you.

@leona-ya leona-ya merged commit ea9949a into NixOS:master Apr 8, 2025
49 of 51 checks passed
@leona-ya leona-ya added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Apr 8, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Apr 8, 2025

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-396939-to-release-24.11 origin/release-24.11
cd .worktree/backport-396939-to-release-24.11
git switch --create backport-396939-to-release-24.11
git cherry-pick -x 9267af0cc66f296cb5b7a52d93150d2923eb1050

1 similar comment
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Apr 8, 2025

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-396939-to-release-24.11 origin/release-24.11
cd .worktree/backport-396939-to-release-24.11
git switch --create backport-396939-to-release-24.11
git cherry-pick -x 9267af0cc66f296cb5b7a52d93150d2923eb1050

@commiterate commiterate deleted the update/gitlab-runner branch April 8, 2025 22:50
@wegank wegank mentioned this pull request Apr 19, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants