Skip to content

treewide: remove unneeded string interpolation#396740

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
drupol:push-ktllmlxynmtt
Apr 7, 2025
Merged

treewide: remove unneeded string interpolation#396740
GaetanLepage merged 1 commit intoNixOS:masterfrom
drupol:push-ktllmlxynmtt

Conversation

@drupol
Copy link
Contributor

@drupol drupol commented Apr 7, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: php PHP is a general-purpose scripting language geared towards web development. label Apr 7, 2025
@drupol drupol mentioned this pull request Apr 7, 2025
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 7, 2025
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 396740


x86_64-linux

✅ 1 package built:
  • gclient2nix

aarch64-linux

✅ 1 package built:
  • gclient2nix

x86_64-darwin

✅ 1 package built:
  • gclient2nix

aarch64-darwin

✅ 1 package built:
  • gclient2nix

@GaetanLepage GaetanLepage merged commit f2670dc into NixOS:master Apr 7, 2025
25 of 27 checks passed
@drupol drupol mentioned this pull request Apr 8, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: php PHP is a general-purpose scripting language geared towards web development. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants