Skip to content

linuxPackages.digimend: 13 -> 13-unstable-2025-01-02#396730

Merged
pbsds merged 1 commit intoNixOS:masterfrom
PuercoPop:update-digimend
May 1, 2025
Merged

linuxPackages.digimend: 13 -> 13-unstable-2025-01-02#396730
pbsds merged 1 commit intoNixOS:masterfrom
PuercoPop:update-digimend

Conversation

@PuercoPop
Copy link
Contributor

@PuercoPop PuercoPop commented Apr 7, 2025 •
edited by pbsds
Loading

  • Update the version to the latest commit, f3c7c7f. This includes the changes needed to build digimend for Linux versions >= 6.12. 6.11 has already been removed from the unstable branch.

  • Remove postInstall hook. The file the hook is trying to remove is no longer there. It was removed in commit 3e41e85.

pbsds edit: closes #373869 closes #378830

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@PuercoPop PuercoPop self-assigned this Apr 7, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Apr 7, 2025
@PuercoPop
Copy link
Contributor Author

PuercoPop commented Apr 7, 2025

@SohamG @sternenseemann I've added you as reviewers because you had opened #373869 and #378830. I went with shipping digimend head instead of back-porting the fix. Hope you don't mind

@acid-bong
Copy link
Contributor

acid-bong commented Apr 7, 2025

Given that the tags still exist in the upstream repo, better use LATESTTAG-unstable-DATE format

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 7, 2025
@PuercoPop PuercoPop changed the title linuxPackages.digimend: 13 -> unstable-2025-01-02 linuxPackages.digimend: 13 -> 13-unstable-2025-01-02 Apr 7, 2025
@PuercoPop
Copy link
Contributor Author

PuercoPop commented Apr 7, 2025 •
edited
Loading

@acid-bong Thanks for the tip. Makes sense, that way versions keep monotonically increasing, even when we switch back to a released version after they release a new version.
Done

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 7, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Apr 7, 2025
@SohamG
Copy link
Contributor

SohamG commented Apr 7, 2025

People involved in digimend have said (#363873) that its preferred to use upstream Linux (ie newer kernels) as Digimend itself is 1) unmaintained 2) downstream of the development in the kernel.

I came to know of this after I opened my PR, and I am now of the opinion that there is little benefit in maintaining this unless support for old kernels is a high priority goal. IMO, generally using a newer kernel just means more features (for free!) so I don't find it that critical. Moreover, it is clear that Digimend is no longer actively maintained.

I am hesitant to give an affirmative review for these reasons (not that my review means much...)

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 8, 2025
@PuercoPop
linuxPackages.digimend: 13 -> 13-unstable-2025-01-02
7d82434 
- Update the version to the latest commit, [f3c7c7f]. This includes the changes
  needed to build digimend for Linux versions >= 6.12. 6.11 has already been
  removed from the unstable branch.

- Remove postInstall hook. The file the hook is trying to remove is no longer
  there. It was removed in commit [3e41e85].

[f3c7c7f]: DIGImend/digimend-kernel-drivers@f3c7c7f
[3e41e85]: DIGImend/digimend-kernel-drivers@3e41e85
tvlbot pushed a commit to tvlfyi/kit that referenced this pull request Apr 20, 2025
@sternenseemann
chore(3p/sources): Bump channels & overlays
fa04178 
- //3p/overlays/tvl:

  - Drop upstreamed thttpd override.
    NixOS/nixpkgs#370071

  - Update telega.el and pin tdlib to compatible version.

- Some packages were affected by the change from fetchCargoTarball to
  fetchCargoVendor which invalidates all cargoSha256 hashes without
  explaining this to the user in any way. See
  <NixOS/nixpkgs#394012>.

  - //users/emery/pkgs/syndicate-server: can be removed anyways
  - //third_party/nixpkgs:grpc-health-check: override is unnecessary now
  - //third_party/nixpkgs:harmonia: updated cargoSha256

- //tvix: address some new clippy lints

- //tvix/cli: Reflect combined graphical iso change.
  http://github.com/nixos/nixpkgs/commit/a2636dae467e16b48

- //tvix/*-go: rerun protoc on protobuf definitions

- //users/aspen/system/yeren:
  Use default kernel version from nixpkgs as 6.11 is EOL.
  This means DIGImend is no longer supported. Hopefully whatever tablet
  aspen is using is supported by upstream now. See also
  - https://spbnick.github.io/2024/11/03/Letting-go-of-DIGImend.html
  - NixOS/nixpkgs#363873
  - NixOS/nixpkgs#396730
  - NixOS/nixpkgs#378830

Change-Id: If8be8b336fc6d8652ecab087decc6fbbc0509647
Reviewed-on: https://cl.tvl.fyi/c/depot/+/13276
Autosubmit: sterni <[email protected]>
Reviewed-by: emery <[email protected]>
Reviewed-by: tazjin <[email protected]>
Reviewed-by: aspen <[email protected]>
Tested-by: BuildkiteCI
tvlbot pushed a commit to tvlfyi/tvix that referenced this pull request Apr 20, 2025
@sternenseemann
chore(3p/sources): Bump channels & overlays
3848c94 
- //3p/overlays/tvl:

  - Drop upstreamed thttpd override.
    NixOS/nixpkgs#370071

  - Update telega.el and pin tdlib to compatible version.

- Some packages were affected by the change from fetchCargoTarball to
  fetchCargoVendor which invalidates all cargoSha256 hashes without
  explaining this to the user in any way. See
  <NixOS/nixpkgs#394012>.

  - //users/emery/pkgs/syndicate-server: can be removed anyways
  - //third_party/nixpkgs:grpc-health-check: override is unnecessary now
  - //third_party/nixpkgs:harmonia: updated cargoSha256

- //tvix: address some new clippy lints

- //tvix/cli: Reflect combined graphical iso change.
  http://github.com/nixos/nixpkgs/commit/a2636dae467e16b48

- //tvix/*-go: rerun protoc on protobuf definitions

- //users/aspen/system/yeren:
  Use default kernel version from nixpkgs as 6.11 is EOL.
  This means DIGImend is no longer supported. Hopefully whatever tablet
  aspen is using is supported by upstream now. See also
  - https://spbnick.github.io/2024/11/03/Letting-go-of-DIGImend.html
  - NixOS/nixpkgs#363873
  - NixOS/nixpkgs#396730
  - NixOS/nixpkgs#378830

Change-Id: If8be8b336fc6d8652ecab087decc6fbbc0509647
Reviewed-on: https://cl.tvl.fyi/c/depot/+/13276
Autosubmit: sterni <[email protected]>
Reviewed-by: emery <[email protected]>
Reviewed-by: tazjin <[email protected]>
Reviewed-by: aspen <[email protected]>
Tested-by: BuildkiteCI
@PuercoPop
Copy link
Contributor Author

PuercoPop commented Apr 21, 2025

People involved in digimend have said (#363873) that its preferred to use
upstream Linux (ie newer kernels) as Digimend itself is 1) unmaintained 2)
downstream of the development in the kernel.

I had seen the post before the PR. I looked into hid-bpf and I agree it is a better design and hopefully the future! However I was unable to understand how
to get it working on my system. Presumably I need something else besides the udev rules? I found someone using
huion-siwtcher. https://github.com/dramforever/config/blob/83db60b3604d015d735a6272afa7906f0f77ba7c/sakuya/tablet.nix#L6
but I haven't yet been able to get it to work on my machine.

I am now of the opinion that there is little benefit in maintaining this

The benefit is that digimend works. I do agree that we should deprecate digimend although first the migration path should be clearly documented.

Moreover, it is clear that Digimend is no longer actively maintained.

I would say it not actively developed, but it is maintained. In that there are people with a commit bit that care about the package enough to at least make sure it builds.

I am hesitant to give an affirmative review for these reasons (not that my review means much...)

That ok, if you are no longer using the package, I mostly wanted someone to check it builds for them as well. In the interested of having the unstable channel building I'll merge the PR later today

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 21, 2025
@PuercoPop
Copy link
Contributor Author

PuercoPop commented Apr 22, 2025

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

nixpkgs-merge-bot bot commented Apr 22, 2025

@PuercoPop merge not permitted (#305350):
pkgs/os-specific/linux/digimend/default.nix is not in pkgs/by-name/

@pbsds pbsds added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label May 1, 2025
@pbsbot
Copy link

pbsbot commented May 1, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 396730

x86_64-linux

⏩ 2 packages marked as broken and skipped:
  • linuxKernel.packages.linux_5_4_hardened.digimend
  • linuxPackages_5_4_hardened.digimend
❌ 2 packages failed to build:
  • linuxKernel.packages.linux_5_10.digimend
  • linuxPackages_latest-libre.digimend (linuxKernel.packages.linux_latest_libre.digimend)
✅ 19 packages built:
  • linuxPackages_5_10_hardened.digimend (linuxKernel.packages.linux_5_10_hardened.digimend)
  • linuxKernel.packages.linux_5_15.digimend
  • linuxPackages_5_15_hardened.digimend (linuxKernel.packages.linux_5_15_hardened.digimend)
  • linuxKernel.packages.linux_5_4.digimend
  • linuxKernel.packages.linux_6_1.digimend
  • linuxPackages.digimend (linuxKernel.packages.linux_6_12.digimend)
  • linuxPackages_hardened.digimend (linuxPackages_6_12_hardened.digimend)
  • linuxKernel.packages.linux_6_13.digimend
  • linuxPackages_6_13_hardened.digimend (linuxKernel.packages.linux_6_13_hardened.digimend)
  • linuxPackages_latest.digimend (linuxKernel.packages.linux_6_14.digimend)
  • linuxPackages_6_1_hardened.digimend (linuxKernel.packages.linux_6_1_hardened.digimend)
  • linuxKernel.packages.linux_6_6.digimend
  • linuxPackages_6_6_hardened.digimend (linuxKernel.packages.linux_6_6_hardened.digimend)
  • linuxPackages_ham.digimend (linuxKernel.packages.linux_ham.digimend)
  • linuxPackages-libre.digimend (linuxKernel.packages.linux_libre.digimend)
  • linuxPackages_lqx.digimend (linuxKernel.packages.linux_lqx.digimend)
  • linuxPackages_xanmod.digimend (linuxKernel.packages.linux_xanmod.digimend)
  • linuxPackages_xanmod_latest.digimend (linuxKernel.packages.linux_xanmod_latest.digimend, linuxPackages_xanmod_stable.digimend)
  • linuxPackages_zen.digimend (linuxKernel.packages.linux_zen.digimend)

@pbsds
Copy link
Member

pbsds commented May 1, 2025

image
LGTM

@pbsds pbsds merged commit 302f82f into NixOS:master May 1, 2025
36 checks passed
@mdaniels5757 mdaniels5757 mentioned this pull request Jun 18, 2025
Open
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@SohamG SohamG Awaiting requested review from SohamG

Assignees

@PuercoPop PuercoPop

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@PuercoPop @acid-bong @SohamG @pbsbot @pbsds @wegank