Skip to content

avahi: add patch fixing libevent name in the .pc file#396426

Merged
pbsds merged 1 commit intoNixOS:stagingfrom
marcin-serwin:push-zwxrryrmlwww
Jun 6, 2025
Merged

avahi: add patch fixing libevent name in the .pc file#396426
pbsds merged 1 commit intoNixOS:stagingfrom
marcin-serwin:push-zwxrryrmlwww

Conversation

@marcin-serwin
Copy link
Contributor

avahi references the libevent incorrectly which causes packages trying to use the avahi-libevent.pc file to fail.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

`avahi` references the libevent incorrectly which causes packages trying
to use the `avahi-libevent.pc` file to fail.
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Apr 5, 2025
@nix-owners nix-owners bot requested review from globin and lovek323 April 5, 2025 21:16
@illdefined
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 396426 --package avahi


x86_64-linux

✅ 3 packages built:
  • avahi
  • avahi.dev (avahi.dev.dev, avahi.dev.man)
  • avahi.man (avahi.man.dev, avahi.man.man)

@illdefined
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 396426 --checkout commit --package avahi


x86_64-linux

✅ 3 packages built:
  • avahi
  • avahi.dev (avahi.dev.dev, avahi.dev.man)
  • avahi.man (avahi.man.dev, avahi.man.man)

aarch64-linux

✅ 3 packages built:
  • avahi
  • avahi.dev (avahi.dev.dev, avahi.dev.man)
  • avahi.man (avahi.man.dev, avahi.man.man)

Copy link
Contributor

@illdefined illdefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the package outputs for x86_64-linux and aarch64-linux and they look good to me.

This is a minor fix which has already been merged upstream five years ago, and I was surprised to see that there hasn’t been any release since then.

@illdefined illdefined added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 22, 2025
@pbsds
Copy link
Member

pbsds commented Jun 6, 2025

built avahi.tests on x86_64-linux and aarch64-linux

@pbsds pbsds merged commit 2360716 into NixOS:staging Jun 6, 2025
28 checks passed
@marcin-serwin marcin-serwin deleted the push-zwxrryrmlwww branch June 23, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants