graphite2: point to correct includedir in the .pc file#395765
Merged
7c6f434c merged 1 commit intoNixOS:stagingfrom Apr 4, 2025
Merged
graphite2: point to correct includedir in the .pc file#3957657c6f434c merged 1 commit intoNixOS:stagingfrom
7c6f434c merged 1 commit intoNixOS:stagingfrom
Conversation
The CMakeLists.txt assumes that the include headers will end up in the same directory as the lib files. This is not the case in this derivation since we separate out from dev making the emitted .pc file reference nonexisting directory.
13 tasks
github-actions
bot
added
10.rebuild-darwin: 5001+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CMakeLists.txt assumes that the include headers will end up in the same directory as the lib files. This is not the case in this derivation since we separate out from dev making the emitted .pc file reference nonexisting directory.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.