Skip to content

Conversation

@drupol
Copy link
Contributor

@drupol drupol commented Apr 2, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 2, 2025
@nix-owners nix-owners bot requested a review from natsukium April 2, 2025 17:44
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 2, 2025
@drupol drupol force-pushed the push-ylosvyxuyons branch from 129baa4 to 7c05101 Compare April 2, 2025 18:04
@drupol drupol force-pushed the push-ylosvyxuyons branch from 7c05101 to f9f3877 Compare April 2, 2025 19:29
@github-actions github-actions bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 2, 2025
@drupol drupol force-pushed the push-ylosvyxuyons branch from f9f3877 to a5469d3 Compare April 2, 2025 20:33
@drupol drupol force-pushed the push-ylosvyxuyons branch from a5469d3 to 6f315d2 Compare April 2, 2025 21:16
@drupol drupol force-pushed the push-ylosvyxuyons branch from 6f315d2 to fcd2e4b Compare April 2, 2025 21:22
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 395541


x86_64-linux

⏩ 8 packages marked as broken and skipped:
  • python313Packages.swh-export
  • python313Packages.swh-export.dist
  • python313Packages.swh-objstorage
  • python313Packages.swh-objstorage.dist
  • python313Packages.swh-scheduler
  • python313Packages.swh-scheduler.dist
  • python313Packages.swh-storage
  • python313Packages.swh-storage.dist
✅ 18 packages built:
  • apache-orc
  • python312Packages.pyorc
  • python312Packages.pyorc.dist
  • python312Packages.pytest-kafka
  • python312Packages.pytest-kafka.dist
  • python312Packages.swh-export
  • python312Packages.swh-export.dist
  • python312Packages.swh-objstorage
  • python312Packages.swh-objstorage.dist
  • python312Packages.swh-scheduler
  • python312Packages.swh-scheduler.dist
  • python312Packages.swh-storage
  • python312Packages.swh-storage.dist
  • python313Packages.pyorc
  • python313Packages.pyorc.dist
  • python313Packages.pytest-kafka
  • python313Packages.pytest-kafka.dist
  • swh

aarch64-linux

⏩ 8 packages marked as broken and skipped:
  • python313Packages.swh-export
  • python313Packages.swh-export.dist
  • python313Packages.swh-objstorage
  • python313Packages.swh-objstorage.dist
  • python313Packages.swh-scheduler
  • python313Packages.swh-scheduler.dist
  • python313Packages.swh-storage
  • python313Packages.swh-storage.dist
✅ 18 packages built:
  • apache-orc
  • python312Packages.pyorc
  • python312Packages.pyorc.dist
  • python312Packages.pytest-kafka
  • python312Packages.pytest-kafka.dist
  • python312Packages.swh-export
  • python312Packages.swh-export.dist
  • python312Packages.swh-objstorage
  • python312Packages.swh-objstorage.dist
  • python312Packages.swh-scheduler
  • python312Packages.swh-scheduler.dist
  • python312Packages.swh-storage
  • python312Packages.swh-storage.dist
  • python313Packages.pyorc
  • python313Packages.pyorc.dist
  • python313Packages.pytest-kafka
  • python313Packages.pytest-kafka.dist
  • swh

x86_64-darwin

✅ 9 packages built:
  • apache-orc
  • python312Packages.pyorc
  • python312Packages.pyorc.dist
  • python312Packages.pytest-kafka
  • python312Packages.pytest-kafka.dist
  • python313Packages.pyorc
  • python313Packages.pyorc.dist
  • python313Packages.pytest-kafka
  • python313Packages.pytest-kafka.dist

aarch64-darwin

✅ 9 packages built:
  • apache-orc
  • python312Packages.pyorc
  • python312Packages.pyorc.dist
  • python312Packages.pytest-kafka
  • python312Packages.pytest-kafka.dist
  • python313Packages.pyorc
  • python313Packages.pyorc.dist
  • python313Packages.pytest-kafka
  • python313Packages.pytest-kafka.dist

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GaetanLepage GaetanLepage merged commit 1cf9304 into NixOS:master Apr 2, 2025
23 of 27 checks passed
@drupol drupol deleted the push-ylosvyxuyons branch April 2, 2025 21:50
dongjoon-hyun pushed a commit to apache/orc that referenced this pull request Apr 8, 2025
…Reader)`

### What changes were proposed in this pull request?

Add missing includes in source files

### Why are the changes needed?

To package `orc` in The Linux NixOS distribution. The [PR](NixOS/nixpkgs#395541) has already be merged, it will be available to the public very soon ([PR tracker](https://nixpkgs-tracker.ocfox.me/?pr=395541)). This is [the commit](NixOS/nixpkgs@48ff182) to add `apache-orc` to NixOS in a **reproducible way**.

### How was this patch tested?

Compilation is now successfully achieved with the patch.

### Was this patch authored or co-authored using generative AI tooling?

Absolutely not.

Closes #2175 from drupol/push-yvkkqmxxmzxl.

Authored-by: Pol Dellaiera <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun pushed a commit to apache/orc that referenced this pull request Apr 8, 2025
…Reader)`

### What changes were proposed in this pull request?

Add missing includes in source files

### Why are the changes needed?

To package `orc` in The Linux NixOS distribution. The [PR](NixOS/nixpkgs#395541) has already be merged, it will be available to the public very soon ([PR tracker](https://nixpkgs-tracker.ocfox.me/?pr=395541)). This is [the commit](NixOS/nixpkgs@48ff182) to add `apache-orc` to NixOS in a **reproducible way**.

### How was this patch tested?

Compilation is now successfully achieved with the patch.

### Was this patch authored or co-authored using generative AI tooling?

Absolutely not.

Closes #2175 from drupol/push-yvkkqmxxmzxl.

Authored-by: Pol Dellaiera <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit af48c5d)
Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun pushed a commit to apache/orc that referenced this pull request Apr 8, 2025
…Reader)`

### What changes were proposed in this pull request?

Add missing includes in source files

### Why are the changes needed?

To package `orc` in The Linux NixOS distribution. The [PR](NixOS/nixpkgs#395541) has already be merged, it will be available to the public very soon ([PR tracker](https://nixpkgs-tracker.ocfox.me/?pr=395541)). This is [the commit](NixOS/nixpkgs@48ff182) to add `apache-orc` to NixOS in a **reproducible way**.

### How was this patch tested?

Compilation is now successfully achieved with the patch.

### Was this patch authored or co-authored using generative AI tooling?

Absolutely not.

Closes #2175 from drupol/push-yvkkqmxxmzxl.

Authored-by: Pol Dellaiera <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit af48c5d)
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants