Skip to content

separateDebugInfo: add symlinks to executable and source for debuginfod support#394674

Merged
symphorien merged 10 commits intoNixOS:stagingfrom
symphorien:separatedebuginfo_debuginfod_support
Jun 20, 2025
Merged

separateDebugInfo: add symlinks to executable and source for debuginfod support#394674
symphorien merged 10 commits intoNixOS:stagingfrom
symphorien:separatedebuginfo_debuginfod_support

Conversation

@symphorien
Copy link
Member

For debuginfod support we must be able to map a build-id to

  • debug symbols
  • the original elf file for which the debug symbols where separated
  • the corresponding source files

Currently, hydra provides an index from build-id to the nar of the debug output containing the debug symbols.

Add symlinks in these outputs so that we can recover the store path of the source and original elf file. We can then fetch them by the normal binary cache protocol.

Pros:

  • we could host an official instance of such a debuginfod server

Cons

A proof of concept of such debuginfo server is available at https://github.com/symphorien/nixseparatedebuginfod2

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from Ericson2314 March 30, 2025 17:05
@symphorien symphorien changed the base branch from master to staging March 30, 2025 17:07
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 8.has: documentation This PR adds or changes documentation labels Mar 30, 2025
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 30, 2025
@symphorien
Copy link
Member Author

Currently this only allows serving unpatched source. If source files are patched, debuginfod servers can only serve the unpatched source.
Alternatives:

  • systematically copy the source after patchPhase to the $debug output (or another output)
  • detect files modified during patch phase, and only copy those to the $debug output. Somewhat more complex.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: vim Advanced text editor 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 6.topic: games Gaming on NixOS 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion Discuss policies to work in and around Nixpkgs backport release-24.11 labels Mar 30, 2025
@nix-owners
Copy link

nix-owners bot commented Mar 30, 2025

The PR's base branch is set to staging, but 89 commits from the master branch are included. Make sure you know the right base branch for your changes, then:

  • If the changes should go to the master branch, change the base branch to master
  • If the changes should go to the staging branch, rebase your PR onto the merge base with the staging branch:
    # git rebase --onto $(git merge-base upstream/staging HEAD) $(git merge-base upstream/master HEAD)
    git rebase --onto c68937a0a0008af9117305874bd3da814fac1f19 10c515901f74f353957a311035639c0b30cf8bf5
    git push --force-with-lease

@symphorien symphorien force-pushed the separatedebuginfo_debuginfod_support branch from 59845de to dfbb727 Compare March 30, 2025 22:11
@github-actions github-actions bot removed 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: vim Advanced text editor 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: TeX Issues regarding texlive and TeX in general labels Mar 30, 2025
yvan-sraka pushed a commit to supabase/postgres that referenced this pull request Nov 25, 2025
yvan-sraka pushed a commit to supabase/postgres that referenced this pull request Nov 25, 2025
jfroche added a commit to supabase/postgres that referenced this pull request Nov 26, 2025
yvan-sraka pushed a commit to supabase/postgres that referenced this pull request Nov 26, 2025
yvan-sraka pushed a commit to supabase/postgres that referenced this pull request Dec 1, 2025
yvan-sraka pushed a commit to supabase/postgres that referenced this pull request Dec 2, 2025
yvan-sraka pushed a commit to supabase/postgres that referenced this pull request Dec 3, 2025
yvan-sraka pushed a commit to supabase/postgres that referenced this pull request Dec 4, 2025
yvan-sraka pushed a commit to supabase/postgres that referenced this pull request Dec 4, 2025
yvan-sraka pushed a commit to supabase/postgres that referenced this pull request Dec 7, 2025
yvan-sraka pushed a commit to supabase/postgres that referenced this pull request Dec 8, 2025
yvan-sraka pushed a commit to supabase/postgres that referenced this pull request Dec 8, 2025
yvan-sraka pushed a commit to supabase/postgres that referenced this pull request Dec 8, 2025
yvan-sraka pushed a commit to supabase/postgres that referenced this pull request Dec 8, 2025
yvan-sraka pushed a commit to supabase/postgres that referenced this pull request Dec 8, 2025
yvan-sraka pushed a commit to supabase/postgres that referenced this pull request Dec 8, 2025
yvan-sraka pushed a commit to supabase/postgres that referenced this pull request Dec 8, 2025
yvan-sraka pushed a commit to supabase/postgres that referenced this pull request Dec 8, 2025
yvan-sraka pushed a commit to supabase/postgres that referenced this pull request Dec 9, 2025
yvan-sraka pushed a commit to supabase/postgres that referenced this pull request Dec 9, 2025
samrose pushed a commit to supabase/postgres that referenced this pull request Dec 11, 2025
yvan-sraka pushed a commit to supabase/postgres that referenced this pull request Dec 11, 2025
yvan-sraka pushed a commit to supabase/postgres that referenced this pull request Dec 12, 2025
samrose pushed a commit to supabase/postgres that referenced this pull request Dec 12, 2025
samrose pushed a commit to supabase/postgres that referenced this pull request Dec 16, 2025
samrose pushed a commit to supabase/postgres that referenced this pull request Dec 17, 2025
jfroche added a commit to supabase/postgres that referenced this pull request Jan 5, 2026
samrose pushed a commit to supabase/postgres that referenced this pull request Jan 15, 2026
github-merge-queue bot pushed a commit to supabase/postgres that referenced this pull request Jan 15, 2026
* chore: fix missing required `teams` meta attribute

* chore: update old (unsupported) version of nix used in script

* fix: overlay and use our `buildPgrxExtension` function

These overlay packages will be removed once the extensions are updated
to use the new `buildPgrxExtension` function.

* chore: fix formatting

* chore: replace (deprecated) `substituteAll` by `replaceVars`

* chore: update (and refactor) flake inputs

* chore: bump `pgrouting` version to 3.8.0

The previously used version was failing to build:

/build/source/src/common/get_check_data.c: In function 'pgr_SPI_getText':
/build/source/src/common/get_check_data.c:307:28: error: passing argument 1 of 'DatumGetCString' makes integer from pointer without a cast [-Wint-conversion]
  307 |     return DatumGetCString(SPI_getvalue(*tuple, *tupdesc, info.colNumber));
      |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                            |
      |                            char *
In file included from /build/source/include/c_common/postgres_connection.h:29,
                 from /build/source/src/common/get_check_data.c:27:
/nix/store/nn6vpjqlsxxmynwcrsib9agb3hpr5cqj-postgresql-17.4/include/server/postgres.h:335:23: note: expected 'Datum' {aka 'long unsigned int'} but argument is of type 'char *'
  335 | DatumGetCString(Datum X)
      |                 ~~~~~~^
make[2]: *** [src/common/CMakeFiles/common.dir/build.make:149: src/common/CMakeFiles/common.dir/get_check_data.c.o] Error 1

* fix: backport tzdata fixes for postgresql 15

This was discussed upstream here:
https://postgr.es/m/0a997455-5aba-4cf2-a354-d26d8bcbfae6%40technowledgy.de

Also applied by nixpkgs here: NixOS/nixpkgs#342026

* fix: plv8 3.1 requires older v8

We cannot use nodejs.libv8 as it is too new for plv8 3.1.
We will be able to use it with plv8 3.2.

* chore: update fmt

* chore: update cargo-pgrx 1.14.3 cargo hash

* chore(postgresql): add isOrioleDB condition

* fix: pgregress tests

* fix: update schema for dbmate schema_migrations table

dbmate 2.27 is now using a varchar for the version column in the
schema_migrations table.

See amacneil/dbmate#641

* Structured attributes are now required when building with separateDebugInfo

See NixOS/nixpkgs#394674

* chore: version bump

* fix: rebase on develop and fix code api changes from nixpkgs

* tests: try to get passing tests

* feat: pin icu75 for postgres build to maintain compat with existing
deployments

* chore: remove commented out code not needed in latest changes to pg

* fix: apparently incorrectly rebased changes, and % nix fmt

* chore: remove nixpkgs-pgbackrest input, and % nix flake update

* fix: replace deprecated v8 package, and wrong packages arguments

* chore: fix formatting

* fix(darwin): remove reference to apple-sdk

* fix(ext): missing required attributes in some extension tests

* chore: % nix flake update && nix fmt

Updated nixpkgs, rust-overlay, and nix-fast-build to latest versions.

* fix(orioledb): fixed installedExtensions reference to use proper self.packages

* fix(postgresql): remove redundant patch substitutions

Removed duplicate substituteInPlace calls that were redundantly applied during previous merge operations. Cleaned up the patch application to avoid duplicate substitutions.

* fix(pgrx): remove deprecated darwin.apple_sdk.frameworks.Security

* fix(postgis): remove custom sfcgal package dependency

Updated postgis.nix to use nixpkgs sfcgal instead of our custom package,
eliminating the need to maintain a separate sfcgal build definition.

* fix(pg_net): pin curl to older nixpkgs version

pg_net requires an older version of curl (pinned from nixpkgs commit
a76c4553d7e741e17f289224eda135423de0491d) to resolve build compatibility issues.

* fix(pgrx): error: multiple input filenames provided

Updated cargo-pgrx buildPgrxExtension with rustc wrapper to handle empty
postmaster_stub.rs files that cause duplicate symbol errors.
(first two filenames are `` and
`/build/tmp.*/postmaster_stubs/nix/store/*/bin/postmaster_stub.rs`)

pg_jsonschema cargo checks fails on specific versions (0.2.0, 0.3.1, 0.3.3).

* fix(tests): updated test expectations

Remove deprecated functions that were removed in newer pgrouting versions
(_pgr_betweennesscentrality and _pgr_contractionhierarchies).

* feat: (re)add check_pg_regress method to PostgresExtensionTest

* refactor: replace fetchTarball with flake input for nixpkgs-oldstable

Improves reproducibility and avoids evaluation-time network access by
using a proper flake input instead of fetchTarball for the older nixpkgs
needed by pg_net and plv8.

* fix(pg_net): disable dangling-assignment warning for v0.19.5 on aarch64-darwin

Version 0.19.5 has a dangling pointer issue in src/core.c:177 that causes
compilation to fail on aarch64-darwin with newer clang versions. This adds
-Wno-error=dangling-assignment to allow compilation to proceed.

The flag is restricted to aarch64-darwin only since GCC on Linux doesn't
recognize this warning option.

* fix(plv8): add headerpad_max_install_names for macOS builds

Add -headerpad_max_install_names linker flag to prevent 'install_name_tool:
changing install names or rpaths can't be redone' errors on macOS. This
allocates sufficient header space for install_name_tool to modify the
shared library during post-install processing.

* fix(tests): correct library naming and symlinks for background worker extensions

Test assertions were inconsistent: expecting {version}.so and {extension_name}-{version}.so
patterns while actual libraries use {lib_name}-{version}.so (e.g. pg_partman_bgw-5.3.1.so,
timescaledb-loader-2.16.1.so). Updated PostgresExtensionTest to accept Optional[str] lib_name
parameter and use consistent {lib_name}-{version}.so assertions throughout.

Added missing timescaledb-loader.so symlink creation and updated the switch script to
maintain both symlinks when switching versions.

Fixes 'Expected timescaledb version 2.16.1, but found timescaledb-loader-2.16.1.so' and
'Expected pg_partman version 5.3.1, but found pg_partman_bgw-5.3.1.so' test failures.

* refactor(exts): replace nixpkgs-oldstable with specific overlay packages

Use overlay instead of passing full nixpkgs-oldstable to avoid exposing
entire old nixpkgs attribute set. Now provides specific packages
(curl_8_4, v8_oldstable) through overlay.

* fix: restore revision support for orioledb builds (introduced it #1880)

Keep revision support that was accidentally simplified during nixpkgs update.
Restores conditional logic to support building orioledb from specific git
revision hashes instead of only tags.

* fix(exts): remove old files that were moved to subdirectories

These files were moved to subdirectories and the old .nix files should be
removed since they were moved to new directory structure with default.nix files.

* fix(flake): remove nixpkgs-go124 and nix-fast-build dependencies

Remove nixpkgs-go124 dependency since current nixpkgs has Go 1.25.4
which is sufficient for packer. Remove nix-fast-build input as unused
and add follows directives to resolve duplicate dependencies.

* fix(flake): update flake.lock and cargo-pgrx hashes

Run flake-linter to eliminate duplicate dependencies, and remove unused
cargo-pgrx / rustc versions hashes.

* fix(exts): remove remaining duplicated files

Move pgrouting.nix to pgrouting/default.nix and groonga package to
pgroonga/groonga.nix. Update imports and fix relative paths for versions.json
and patch files.

* refactor(pgrx): conditionally apply rustc wrapper when < 0.12

Replace inline bash script generation with writeShellScriptBin for rustc
wrapper that filters empty postmaster_stub.rs arguments. Apply wrapper only
for pgrx < 0.12 since issue was fixed upstream in pgrx#1435 and pgrx#1441.

* refactor(nixpkgs): use let binding for oldstable instead of overlay

Move nixpkgs-oldstable import to a let binding to avoid importing it
three times...

* refactor(groonga): move groonga package to pgroonga extension

Remove supabase-groonga from global flake packages and import it locally
in pgroonga extension instead. Other components access groonga via
pgroonga.passthru.groonga since groonga is only used by pgroonga.

* fix(ansible): remove supabase-groonga from package install list

The supabase-groonga package was moved to pgroonga extension in commit 1f0ed1f,
but Ansible was still trying to install it separately causing build failures.

* Revert "fix(ansible): remove supabase-groonga from package install list"

This reverts commit 55474686405394826ad07a032cbcf0e36a924554.

* Revert "refactor(groonga): move groonga package to pgroonga extension"

This reverts commit cfa9bcb92219f391469ae743f95c8856b0a99561.

* fix(darwin): remove deprecated apple_sdk frameworks from supascan

Remove references to darwin.apple_sdk.frameworks.{IOKit,CoreFoundation}
which have been deprecated in nixpkgs. Disable CGO to avoid Darwin
framework dependencies entirely.

* chore: bump version suffix to test

* chore: bump to retest

* chore: suffix to test

* chore: bump to test

* feat: update nixpkgs and fix plpgsql-check build with gcc 15

With this new nixpkgs update come gcc 15, which introduced stricter C standard compliance. plpgsql-check fails to build due to this.
To fix the build, we explicitly set the C standard to gnu17.

* fix: nix version update

nix 2.29 doesn't exist in the updated nixpkgs anymore

* fix: replace all deprecated system attribute usages

Replace deprecated system attribute accesses throughout the codebase with
stdenv.hostPlatform.system to resolve Nix deprecation warnings.

Changes:
- Replace inherit (stdenv) system with system = stdenv.hostPlatform.system
- Replace pkgs.system with pkgs.stdenv.hostPlatform.system (55 occurrences)
- Replace system function parameters with stdenv to avoid auto-injection
- Replace final.system in overlay with final.stdenv.hostPlatform.system

Affected files:
- nix/postgresql/generic.nix
- nix/packages/default.nix
- nix/ext/tests/*.nix (16 files)
- nix/packages/lib.nix
- nix/packages/dbmate-tool.nix
- nix/packages/show-commands.nix
- nix/cargo-pgrx/mkPgrxExtension.nix
- nix/overlays/default.nix

* chore: bump versions for testing

* chore: bump version to release

---------

Co-authored-by: Yvan Sraka <[email protected]>
Co-authored-by: Sam Rose <[email protected]>
Co-authored-by: samrose <[email protected]>
github-merge-queue bot pushed a commit to supabase/postgres that referenced this pull request Jan 27, 2026
* chore: fix missing required `teams` meta attribute

* chore: update old (unsupported) version of nix used in script

* fix: overlay and use our `buildPgrxExtension` function

These overlay packages will be removed once the extensions are updated
to use the new `buildPgrxExtension` function.

* chore: fix formatting

* chore: replace (deprecated) `substituteAll` by `replaceVars`

* chore: update (and refactor) flake inputs

* chore: bump `pgrouting` version to 3.8.0

The previously used version was failing to build:

/build/source/src/common/get_check_data.c: In function 'pgr_SPI_getText':
/build/source/src/common/get_check_data.c:307:28: error: passing argument 1 of 'DatumGetCString' makes integer from pointer without a cast [-Wint-conversion]
  307 |     return DatumGetCString(SPI_getvalue(*tuple, *tupdesc, info.colNumber));
      |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                            |
      |                            char *
In file included from /build/source/include/c_common/postgres_connection.h:29,
                 from /build/source/src/common/get_check_data.c:27:
/nix/store/nn6vpjqlsxxmynwcrsib9agb3hpr5cqj-postgresql-17.4/include/server/postgres.h:335:23: note: expected 'Datum' {aka 'long unsigned int'} but argument is of type 'char *'
  335 | DatumGetCString(Datum X)
      |                 ~~~~~~^
make[2]: *** [src/common/CMakeFiles/common.dir/build.make:149: src/common/CMakeFiles/common.dir/get_check_data.c.o] Error 1

* fix: backport tzdata fixes for postgresql 15

This was discussed upstream here:
https://postgr.es/m/0a997455-5aba-4cf2-a354-d26d8bcbfae6%40technowledgy.de

Also applied by nixpkgs here: NixOS/nixpkgs#342026

* fix: plv8 3.1 requires older v8

We cannot use nodejs.libv8 as it is too new for plv8 3.1.
We will be able to use it with plv8 3.2.

* chore: update fmt

* chore: update cargo-pgrx 1.14.3 cargo hash

* chore(postgresql): add isOrioleDB condition

* fix: pgregress tests

* fix: update schema for dbmate schema_migrations table

dbmate 2.27 is now using a varchar for the version column in the
schema_migrations table.

See amacneil/dbmate#641

* Structured attributes are now required when building with separateDebugInfo

See NixOS/nixpkgs#394674

* chore: version bump

* fix: rebase on develop and fix code api changes from nixpkgs

* tests: try to get passing tests

* feat: pin icu75 for postgres build to maintain compat with existing
deployments

* chore: remove commented out code not needed in latest changes to pg

* fix: apparently incorrectly rebased changes, and % nix fmt

* chore: remove nixpkgs-pgbackrest input, and % nix flake update

* fix: replace deprecated v8 package, and wrong packages arguments

* chore: fix formatting

* fix(darwin): remove reference to apple-sdk

* fix(ext): missing required attributes in some extension tests

* chore: % nix flake update && nix fmt

Updated nixpkgs, rust-overlay, and nix-fast-build to latest versions.

* fix(orioledb): fixed installedExtensions reference to use proper self.packages

* fix(postgresql): remove redundant patch substitutions

Removed duplicate substituteInPlace calls that were redundantly applied during previous merge operations. Cleaned up the patch application to avoid duplicate substitutions.

* fix(pgrx): remove deprecated darwin.apple_sdk.frameworks.Security

* fix(postgis): remove custom sfcgal package dependency

Updated postgis.nix to use nixpkgs sfcgal instead of our custom package,
eliminating the need to maintain a separate sfcgal build definition.

* fix(pg_net): pin curl to older nixpkgs version

pg_net requires an older version of curl (pinned from nixpkgs commit
a76c4553d7e741e17f289224eda135423de0491d) to resolve build compatibility issues.

* fix(pgrx): error: multiple input filenames provided

Updated cargo-pgrx buildPgrxExtension with rustc wrapper to handle empty
postmaster_stub.rs files that cause duplicate symbol errors.
(first two filenames are `` and
`/build/tmp.*/postmaster_stubs/nix/store/*/bin/postmaster_stub.rs`)

pg_jsonschema cargo checks fails on specific versions (0.2.0, 0.3.1, 0.3.3).

* fix(tests): updated test expectations

Remove deprecated functions that were removed in newer pgrouting versions
(_pgr_betweennesscentrality and _pgr_contractionhierarchies).

* feat: (re)add check_pg_regress method to PostgresExtensionTest

* refactor: replace fetchTarball with flake input for nixpkgs-oldstable

Improves reproducibility and avoids evaluation-time network access by
using a proper flake input instead of fetchTarball for the older nixpkgs
needed by pg_net and plv8.

* fix(pg_net): disable dangling-assignment warning for v0.19.5 on aarch64-darwin

Version 0.19.5 has a dangling pointer issue in src/core.c:177 that causes
compilation to fail on aarch64-darwin with newer clang versions. This adds
-Wno-error=dangling-assignment to allow compilation to proceed.

The flag is restricted to aarch64-darwin only since GCC on Linux doesn't
recognize this warning option.

* fix(plv8): add headerpad_max_install_names for macOS builds

Add -headerpad_max_install_names linker flag to prevent 'install_name_tool:
changing install names or rpaths can't be redone' errors on macOS. This
allocates sufficient header space for install_name_tool to modify the
shared library during post-install processing.

* fix(tests): correct library naming and symlinks for background worker extensions

Test assertions were inconsistent: expecting {version}.so and {extension_name}-{version}.so
patterns while actual libraries use {lib_name}-{version}.so (e.g. pg_partman_bgw-5.3.1.so,
timescaledb-loader-2.16.1.so). Updated PostgresExtensionTest to accept Optional[str] lib_name
parameter and use consistent {lib_name}-{version}.so assertions throughout.

Added missing timescaledb-loader.so symlink creation and updated the switch script to
maintain both symlinks when switching versions.

Fixes 'Expected timescaledb version 2.16.1, but found timescaledb-loader-2.16.1.so' and
'Expected pg_partman version 5.3.1, but found pg_partman_bgw-5.3.1.so' test failures.

* refactor(exts): replace nixpkgs-oldstable with specific overlay packages

Use overlay instead of passing full nixpkgs-oldstable to avoid exposing
entire old nixpkgs attribute set. Now provides specific packages
(curl_8_4, v8_oldstable) through overlay.

* fix: restore revision support for orioledb builds (introduced it #1880)

Keep revision support that was accidentally simplified during nixpkgs update.
Restores conditional logic to support building orioledb from specific git
revision hashes instead of only tags.

* fix(exts): remove old files that were moved to subdirectories

These files were moved to subdirectories and the old .nix files should be
removed since they were moved to new directory structure with default.nix files.

* fix(flake): remove nixpkgs-go124 and nix-fast-build dependencies

Remove nixpkgs-go124 dependency since current nixpkgs has Go 1.25.4
which is sufficient for packer. Remove nix-fast-build input as unused
and add follows directives to resolve duplicate dependencies.

* fix(flake): update flake.lock and cargo-pgrx hashes

Run flake-linter to eliminate duplicate dependencies, and remove unused
cargo-pgrx / rustc versions hashes.

* fix(exts): remove remaining duplicated files

Move pgrouting.nix to pgrouting/default.nix and groonga package to
pgroonga/groonga.nix. Update imports and fix relative paths for versions.json
and patch files.

* refactor(pgrx): conditionally apply rustc wrapper when < 0.12

Replace inline bash script generation with writeShellScriptBin for rustc
wrapper that filters empty postmaster_stub.rs arguments. Apply wrapper only
for pgrx < 0.12 since issue was fixed upstream in pgrx#1435 and pgrx#1441.

* refactor(nixpkgs): use let binding for oldstable instead of overlay

Move nixpkgs-oldstable import to a let binding to avoid importing it
three times...

* refactor(groonga): move groonga package to pgroonga extension

Remove supabase-groonga from global flake packages and import it locally
in pgroonga extension instead. Other components access groonga via
pgroonga.passthru.groonga since groonga is only used by pgroonga.

* fix(ansible): remove supabase-groonga from package install list

The supabase-groonga package was moved to pgroonga extension in commit 1f0ed1f,
but Ansible was still trying to install it separately causing build failures.

* Revert "fix(ansible): remove supabase-groonga from package install list"

This reverts commit 55474686405394826ad07a032cbcf0e36a924554.

* Revert "refactor(groonga): move groonga package to pgroonga extension"

This reverts commit cfa9bcb92219f391469ae743f95c8856b0a99561.

* fix(darwin): remove deprecated apple_sdk frameworks from supascan

Remove references to darwin.apple_sdk.frameworks.{IOKit,CoreFoundation}
which have been deprecated in nixpkgs. Disable CGO to avoid Darwin
framework dependencies entirely.

* chore: bump version suffix to test

* feat(pg_repack): use default nixos extension test

Lower the maintenance by reusing the default extension test.

* fix: guard upgrade path checks when support_upgrade is false

Address CodeRabbit review feedback: when support_upgrade is false (e.g., for
pg_repack), the test was still calling check_upgrade_path unconditionally,
which is semantically incorrect.

Fixed by wrapping upgrade path test calls with conditional guards:
- Only call test.check_upgrade_path() when support_upgrade is true
- Applies to both PostgreSQL 15 and 17 test sections
- Extensions like pg_repack (support_upgrade=false) now skip upgrade tests

This ensures test logic matches the extension's actual upgrade capabilities.

---------

Co-authored-by: Yvan Sraka <[email protected]>
Co-authored-by: Sam Rose <[email protected]>
Co-authored-by: samrose <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: stdenv Standard environment 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants