pkg-config: remove requires-private patch#394607
Draft
marcin-serwin wants to merge 8 commits intoNixOS:stagingfrom
Draft
pkg-config: remove requires-private patch#394607marcin-serwin wants to merge 8 commits intoNixOS:stagingfrom
marcin-serwin wants to merge 8 commits intoNixOS:stagingfrom
Conversation
13 tasks
4d7f9ca to
df15a9b
Compare
35d538c to
fed5664
Compare
6cb3e3f to
111f9aa
Compare
2a232c5 to
ea6f822
Compare
ea6f822 to
31d132a
Compare
The CMakeLists.txt assumes that the include headers will end up in the same directory as the lib files. This is not the case in this derivation since we separate out from dev making the emitted .pc file reference nonexisting directory.
`avahi` references the libevent incorrectly which causes packages trying to use the `avahi-libevent.pc` file to fail.
31d132a to
5f13bf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on the following PRs:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.