emacs-macport: 29.4 -> 30.1 by juuyokka · Pull Request #393512 · NixOS/nixpkgs

juuyokka · 2025-03-26T21:19:32Z

Mitsuharu's Emacs fork hasn't been updated for the latest release yet, but there's an experimental fork that rebases his work off of Emacs 30.1. While it's not ready for packaging, I wanted to get started on it in preparation for a stable Mac port. https://github.com/jdtsmith/emacs-mac

On Linux, emacs28 and emacs29 have already been removed as of cd0ef8b. Updating emacs-macport to 30 would allow emacs28-macport and emacs29-macport to be removed as well on Darwin.

Since the addition of the new Darwin SDK framework (apple-sdk) in b904748, there are many extraneous inputs from apple_sdk.frameworks that are no longer needed.

Thank you @jasonjckn for bringing this fork to my attention and for your help.

Closes #392960
Closes #351042

Things done

Add a 👍 reaction to pull requests you find important.

juuyokka · 2025-03-27T01:13:59Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 393512

`aarch64-darwin`

⏩ 2 packages marked as broken and skipped:

emacs28-macport
emacs29-macport

✅ 1 package built:

emacs-macport (emacs30-macport)

amadaluzia

Diff LGTM. I will approve these changes once the port used is stable.

juuyokka · 2025-03-27T02:23:48Z

Fixed the older packages so they can still build. meta.knownVulnerabilities will prevent them from being evaluated in CI though. Removing them entirely could be an option, seeing as they have already been removed on the Linux side in cd0ef8b.

amadaluzia · 2025-03-27T10:24:20Z

Little extra: would you mind adding this for #392960 to the PR? Cheers.

jasonjckn · 2025-03-27T23:32:59Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 393512

`aarch64-darwin`

⏩ 2 packages marked as broken and skipped:

emacs28-macport
emacs29-macport

❌ 2 packages failed to build:

framac
vimacs

✅ 66 packages built:

aerc
afew
afew.dist
afew.doc
afew.man
agda (agdaPackages.agda)
agdaPackages._1lab
agdaPackages.agda-categories
agdaPackages.agda-prelude
agdaPackages.cubical
agdaPackages.cubical-mini
agdaPackages.functional-linear-algebra
agdaPackages.generics
agdaPackages.standard-library
auctex
auctex.tex
cflow
cscope
easycrypt
emacs (emacs30)
emacs-gtk (emacs30-gtk3)
emacs-lsp-booster
emacs-macport (emacs30-macport)
emacs-pgtk (emacs30-pgtk)
haskellPackages.Agda
haskellPackages.Agda.bin
haskellPackages.Agda.data
haskellPackages.Agda.doc
haskellPackages.notmuch
haskellPackages.notmuch.doc
lbdb
lieer
lieer.dist
mu
mu.mu4e
muchsync
mujmap
neomutt
notifymuch
notifymuch.dist
notmuch
notmuch-addrlookup
notmuch-mailmover
notmuch.bindingconfig
notmuch.emacs
notmuch.info
notmuch.man
notmuch.vim (vimPlugins.notmuch-vim, vimPlugins.notmuch-vim.bindingconfig, vimPlugins.notmuch-vim.emacs, vimPlugins.notmuch-vim.info, vimPlugins.notmuch-vim.man, vimPlugins.notmuch-vim.vim)
pycflow2dot (python312Packages.pycflow2dot)
pycflow2dot.dist (python312Packages.pycflow2dot.dist)
python312Packages.notmuch
python312Packages.notmuch.dist
python312Packages.notmuch2
python312Packages.notmuch2.dist
python313Packages.notmuch
python313Packages.notmuch.dist
python313Packages.notmuch2
python313Packages.notmuch2.dist
python313Packages.pycflow2dot
python313Packages.pycflow2dot.dist
rtags
trexio
trexio.dev
tuntox
why3
why3.dev

juuyokka · 2025-03-28T01:31:59Z

❌ 2 packages failed to build:

framac

vimacs

Both of these package appear to be broken for aarch64-darwin on master. I was able to reproduce the build failure on 65eda81.

ArkieSoft · 2025-03-28T02:05:20Z

I was able to reproduce the failures on my machine using
nix build github:NixOS/nixpkgs/65eda81#framac
and
nix build github:NixOS/nixpkgs/65eda81#vimacs

amadaluzia

Diff looks once again OK to me, but I will still choose to wait for jdtsmith to bring his fork out of experimental for approval.

juuyokka · 2025-03-29T15:51:59Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 393512 --extra-nixpkgs-config '{ withNativeCompilation = false; }'

`aarch64-darwin`

⏩ 1 package marked as broken and skipped:

mozart2

❌ 2 packages failed to build:

framac
vimacs

✅ 67 packages built:

aerc
afew
afew.dist
afew.doc
afew.man
agda (agdaPackages.agda)
agdaPackages._1lab
agdaPackages.agda-categories
agdaPackages.agda-prelude
agdaPackages.cubical
agdaPackages.cubical-mini
agdaPackages.functional-linear-algebra
agdaPackages.generics
agdaPackages.standard-library
auctex
auctex.tex
cflow
cscope
easycrypt
emacs (emacs30)
emacs-gtk (emacs30-gtk3)
emacs-lsp-booster
emacs-macport (emacs30-macport)
emacs-nox (emacs30-nox)
emacs-pgtk (emacs30-pgtk)
haskellPackages.Agda
haskellPackages.Agda.bin
haskellPackages.Agda.data
haskellPackages.Agda.doc
haskellPackages.notmuch
haskellPackages.notmuch.doc
lbdb
lieer
lieer.dist
mu
mu.mu4e
muchsync
mujmap
neomutt
notifymuch
notifymuch.dist
notmuch
notmuch-addrlookup
notmuch-mailmover
notmuch.bindingconfig
notmuch.emacs
notmuch.info
notmuch.man
notmuch.vim (vimPlugins.notmuch-vim, vimPlugins.notmuch-vim.bindingconfig, vimPlugins.notmuch-vim.emacs, vimPlugins.notmuch-vim.info, vimPlugins.notmuch-vim.man, vimPlugins.notmuch-vim.vim)
pycflow2dot (python312Packages.pycflow2dot)
pycflow2dot.dist (python312Packages.pycflow2dot.dist)
python312Packages.notmuch
python312Packages.notmuch.dist
python312Packages.notmuch2
python312Packages.notmuch2.dist
python313Packages.notmuch
python313Packages.notmuch.dist
python313Packages.notmuch2
python313Packages.notmuch2.dist
python313Packages.pycflow2dot
python313Packages.pycflow2dot.dist
rtags
trexio
trexio.dev
tuntox
why3
why3.dev

pkgs/applications/editors/emacs/default.nix

pkgs/applications/editors/emacs/make-emacs.nix

pkgs/top-level/all-packages.nix

AndersonTorres · 2025-04-01T02:26:12Z

pkgs/applications/editors/emacs/sources.nix

Was this abandoned, or it is just dormant?

To my knowledge, it is only dormant. There doesn't appear to be a branch for Emacs 30, so I swapped sources to a fork until something stable comes out of the woodwork.

Reflecting the removal of Linux packages in cd0ef8b

Packages in pkgs.darwin.apple_sdk.frameworks are not needed when using pkgs.darwin.apple-sdk (note the dash).

The macport has optional features up to macOS 14, but apple-sdk defaults to 11.3, so none of them will compile. Upgrading the SDK will not impact functionality on older versions of macOS as there are also runtime checks.

deejayem · 2025-04-05T12:36:45Z

For what it's worth, Mitsuharu Yamamoto did a release of 29.4 earlier this week (https://bitbucket.org/mituharu/emacs-mac/commits/55768fe4781855e8cd4af721c8bf0610ed952e97), so the project isn't dead yet. I don't know what that means for when 30.1 might come along though, as he hasn't merged that into his work branch yet.

folliehiyuki · 2025-04-14T16:36:31Z

If I'm not mistaken, emacs-macport package doesn't expose emacs and emacsclient to bin output. Can this be implemented in this PR as well? It's useful for setting up emacs-daemon on Darwin.

infrequentcoder · 2025-04-14T18:12:10Z

If I'm not mistaken, emacs-macport package doesn't expose emacs and emacsclient to bin output. Can this be implemented in this PR as well? It's useful for setting up emacs-daemon on Darwin.

I don’t think this is entirely accurate. I use emacsclient on the command line all the time and debug my config with emacs as needed while using the emacs-macport package.

liaowang11 · 2025-07-11T13:56:47Z

Can you kindly merge the latest nixpkgs so we can enable native compilation?

archer-65 · 2025-07-11T14:32:44Z

I think it would be better to keep both 29.4 and 30.1 until the latter is considered stable.

kfiz · 2025-08-24T22:27:20Z

pkgs/applications/editors/emacs/make-emacs.nix

  acl,
  alsa-lib,
-  apple-sdk,
+  apple-sdk_14,


@juuyokka is apple-sdk_14 the minimum sdk version that is needed for this?

It has additional functionality on newer SDKs. There is no harm in using a newer SDK for a correctly-written application that does runtime availability checks before using newer APIs, and this appears to do so. However, macOS 14 will be the baseline for 25.11 anyway, so it may not be worth explicitly specifying until they implement optional functionality for newer versions.

kfiz · 2025-08-24T22:57:12Z

pkgs/applications/editors/emacs/sources.nix

+  emacs30-macport = import ./make-emacs.nix (mkArgs {
    pname = "emacs-mac";
-    version = "29.1";
+    version = "30.1.50";


@juuyokka I think latest version is now at "30.2.50". See jdtsmith/emacs-mac@34f3540

jian-lin · 2025-09-05T04:57:14Z

emacs-macport users, please review and/or test #440245.

jwiegley · 2025-09-05T16:56:49Z

Btw, I've been using a (slightly modified for unstable) variant of this patch for many weeks now, and all has been working well. I also keep it up to date with jdtsmith's latest Eamcs updates.

what-the-functor · 2025-09-05T19:20:44Z

It has been working well for me also.

Sigmanificient · 2025-10-04T14:34:54Z

Superseeded by: emacs-macport: 29.4 -> 30.2 #440245

github-actions bot added 6.topic: emacs Text editor 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 26, 2025

amadaluzia reviewed Mar 27, 2025

View reviewed changes

juuyokka force-pushed the emacs-mac-macport-30.1 branch from 3e7f57f to 0867c3b Compare March 27, 2025 02:18

github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Mar 27, 2025

juuyokka mentioned this pull request Mar 27, 2025

Update Request: emacs-macport 29.4 → 30.1 #392960

Closed

3 tasks

juuyokka force-pushed the emacs-mac-macport-30.1 branch from 8781db3 to d624c3c Compare March 27, 2025 21:51

juuyokka force-pushed the emacs-mac-macport-30.1 branch 2 times, most recently from 25dee4a to b019b72 Compare March 29, 2025 01:43

amadaluzia reviewed Mar 29, 2025

View reviewed changes

juuyokka changed the title ~~emacs-mac: init at 30.1~~ emacs-macport: init at 30.1 Mar 29, 2025

juuyokka force-pushed the emacs-mac-macport-30.1 branch from 9044e6d to 549313d Compare March 29, 2025 17:44

jian-lin reviewed Mar 30, 2025

View reviewed changes

pkgs/applications/editors/emacs/default.nix Outdated Show resolved Hide resolved

jian-lin reviewed Mar 30, 2025

View reviewed changes

pkgs/applications/editors/emacs/make-emacs.nix Outdated Show resolved Hide resolved

juuyokka force-pushed the emacs-mac-macport-30.1 branch from 549313d to 62a0896 Compare March 30, 2025 17:16

jian-lin reviewed Mar 31, 2025

View reviewed changes

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved

AndersonTorres reviewed Apr 1, 2025

View reviewed changes

wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025

juuyokka added 3 commits April 2, 2025 13:24

emacs-macport: init at 30.1

7252edf

emacs{28,29}-macport: remove

dac423f

Reflecting the removal of Linux packages in cd0ef8b

emacs: remove unnecessary inputs for macport

cd9a65c

Packages in pkgs.darwin.apple_sdk.frameworks are not needed when using pkgs.darwin.apple-sdk (note the dash).

juuyokka added 2 commits April 2, 2025 13:24

emacs-macport: upgrade apple-sdk to apple-sdk_14

c1db941

The macport has optional features up to macOS 14, but apple-sdk defaults to 11.3, so none of them will compile. Upgrading the SDK will not impact functionality on older versions of macOS as there are also runtime checks.

emacs-macport: add lactose to maintainers

e69459d

juuyokka force-pushed the emacs-mac-macport-30.1 branch from 62a0896 to e69459d Compare April 2, 2025 20:24

ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025

archer-65 mentioned this pull request Apr 5, 2025

emacs-macport: 29.1 -> 29.4 #396416

Merged

13 tasks

wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 17, 2025

AndersonTorres mentioned this pull request Apr 24, 2025

Remove references to older emacsen #389689

Closed

13 tasks

what-the-functor mentioned this pull request May 25, 2025

Build success: M3 MacBook Air Sequoia 15.5 Nix jdtsmith/emacs-mac#17

Closed

wolfgangwalther changed the title ~~emacs-macport: init at 30.1~~ emacs-macport: 29.4 -> 30.1 Jul 9, 2025

kfiz reviewed Aug 24, 2025

View reviewed changes

emilazy mentioned this pull request Sep 3, 2025

emacs-macport: use a different hammer for the CF_NOESCAPE bug #435148

Merged

13 tasks

kfiz mentioned this pull request Sep 4, 2025

emacs-macport: 29.4 -> 30.2 #440245

Merged

13 tasks

Sigmanificient closed this Oct 4, 2025

Uh oh!

Conversation

juuyokka commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

juuyokka commented Mar 27, 2025

nixpkgs-review result

aarch64-darwin

Uh oh!

amadaluzia left a comment

Choose a reason for hiding this comment

Uh oh!

juuyokka commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amadaluzia commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasonjckn commented Mar 27, 2025

nixpkgs-review result

aarch64-darwin

Uh oh!

juuyokka commented Mar 28, 2025

Uh oh!

ArkieSoft commented Mar 28, 2025

Uh oh!

amadaluzia left a comment

Choose a reason for hiding this comment

Uh oh!

juuyokka commented Mar 29, 2025

nixpkgs-review result

aarch64-darwin

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AndersonTorres Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

juuyokka Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

deejayem commented Apr 5, 2025

Uh oh!

folliehiyuki commented Apr 14, 2025

Uh oh!

infrequentcoder commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liaowang11 commented Jul 11, 2025

Uh oh!

archer-65 commented Jul 11, 2025

Uh oh!

kfiz Aug 24, 2025

Choose a reason for hiding this comment

Uh oh!

emilazy Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

kfiz Aug 24, 2025

Choose a reason for hiding this comment

Uh oh!

jian-lin commented Sep 5, 2025

Uh oh!

jwiegley commented Sep 5, 2025

Uh oh!

what-the-functor commented Sep 5, 2025

Uh oh!

Sigmanificient commented Oct 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

juuyokka commented Mar 26, 2025 •

edited

Loading

`nixpkgs-review` result

`aarch64-darwin`

juuyokka commented Mar 27, 2025 •

edited

Loading

amadaluzia commented Mar 27, 2025 •

edited

Loading

`nixpkgs-review` result

`aarch64-darwin`

`nixpkgs-review` result

`aarch64-darwin`

infrequentcoder commented Apr 14, 2025 •

edited

Loading