Skip to content

emacs: disable __structuredAttrs for elisp packages for now#393314

Merged
adisbladis merged 1 commit intoNixOS:masterfrom
linj-fork:pr/elisp-structuredattrs-revert
Mar 26, 2025
Merged

emacs: disable __structuredAttrs for elisp packages for now#393314
adisbladis merged 1 commit intoNixOS:masterfrom
linj-fork:pr/elisp-structuredattrs-revert

Conversation

@jian-lin
Copy link
Contributor

@jian-lin jian-lin commented Mar 26, 2025

The issue #392928 fixes seems to affect many elisp packages. For example, about 900 MELPA packages are affected. This commit is a temporary fix and should be reverted after #392928 reaches master.

Close: #388829
Close: nix-community/emacs-overlay#486

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

The issue NixOS#392928 fixes seems to affect many elisp packages.  For
example, about 900 MELPA packages are affected.  This commit is a
temporary fix and should be reverted after NixOS#392928 reaches master.

Close: NixOS#388829
@github-actions github-actions bot added the 6.topic: emacs Text editor label Mar 26, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 26, 2025
@adisbladis adisbladis merged commit 187fb63 into NixOS:master Mar 26, 2025
31 of 35 checks passed
@jian-lin jian-lin deleted the pr/elisp-structuredattrs-revert branch March 26, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: emacs Text editor 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Packages missing after a home-manager switch emacs, (emacs30-nox): emacsPackages no longer visible(?) to emacs

2 participants