nixos/dependency-track: fix nginx config for frontend#393041
Merged
xanderio merged 1 commit intoNixOS:masterfrom Apr 23, 2025
Merged
nixos/dependency-track: fix nginx config for frontend#393041xanderio merged 1 commit intoNixOS:masterfrom
xanderio merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: nixos
xanderio
force-pushed
the
push-xrqnyxrruvms
branch
3 times, most recently
from
4592e2d to
d690c2c
Compare
blitz
approved these changes
Mar 25, 2025
Contributor
blitz
left a comment
blitz
left a comment
There was a problem hiding this comment.
Let's get the fix merged!
Did the broken change get backported? If so, we should also backport this. Also, is there a test that catches misconfigurations like this?
wegank
added
the
12.approvals: 1
Apparend I fell for some browser cache when implementing this in the first place. This patch is based on the upstream nginx config. https://github.com/DependencyTrack/frontend/blob/5f318aca10f85f1f5d7a91d7627883bd506cc48e/docker/etc/nginx/templates/default.conf.template
xanderio
force-pushed
the
push-xrqnyxrruvms
branch
from
d690c2c to
4bc3f43
Compare
snue
approved these changes
Apr 23, 2025
Member
snue
left a comment
snue
left a comment
There was a problem hiding this comment.
Thanks for linking the official config. Looks good.
There is also a sub_filter rewrite and error page handling in the official example. Not required to fix the current issues (no need to change anything in this PR), but do we need/want those eventually? I have not seen any errors with our setup 😁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparend I fell for some browser cache when implementing this in the first place. This patch is based on the upstream nginx config.
https://github.com/DependencyTrack/frontend/blob/5f318aca10f85f1f5d7a91d7627883bd506cc48e/docker/etc/nginx/templates/default.conf.template
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.