Skip to content

[24.11] libblake3: fix build on x86_64-darwin#392846

Merged
wolfgangwalther merged 1 commit intoNixOS:release-24.11from
wolfgangwalther:libblake3
Mar 24, 2025
Merged

[24.11] libblake3: fix build on x86_64-darwin#392846
wolfgangwalther merged 1 commit intoNixOS:release-24.11from
wolfgangwalther:libblake3

Conversation

@wolfgangwalther
Copy link
Contributor

@wolfgangwalther wolfgangwalther commented Mar 24, 2025

Broke in #391418.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 24, 2025
@wolfgangwalther wolfgangwalther mentioned this pull request Mar 24, 2025
Merged
@wolfgangwalther
Copy link
Contributor Author

wolfgangwalther commented Mar 24, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392846

x86_64-darwin

✅ 1 package built:
  • libblake3

aarch64-darwin

✅ 1 package built:
  • libblake3

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 24, 2025
@nix-owners nix-owners bot requested a review from fgaz March 24, 2025 20:31
@wolfgangwalther wolfgangwalther merged commit db8776c into NixOS:release-24.11 Mar 24, 2025
24 of 28 checks passed
@wolfgangwalther wolfgangwalther deleted the libblake3 branch March 24, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fgaz fgaz Awaiting requested review from fgaz

1 more reviewer

@silvanshade silvanshade silvanshade approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wolfgangwalther @silvanshade