Closed
Conversation
leona-ya
force-pushed
the
push-xumymyxwyzlw
branch
from
9222156 to
d0d24e1
Compare
github-actions
bot
added
10.rebuild-darwin: 1
leona-ya
force-pushed
the
push-xumymyxwyzlw
branch
from
d0d24e1 to
25cc19b
Compare
github-actions
bot
added
the
10.rebuild-linux: 1-10
nix-owners
bot
requested review from
globin,
krav,
talyz,
yayayayaka and
zimbatm
drupol
reviewed
Mar 23, 2025
* Switch build invocations to make * Fix build errors on darwin
leona-ya
force-pushed
the
push-xumymyxwyzlw
branch
from
25cc19b to
7dcaf4d
Compare
drupol
reviewed
Mar 27, 2025
|
|
||
| postPatch = '' | ||
| substituteInPlace Makefile --replace-fail "export VERSION := \$(shell ./ci/version)" "export VERSION := ${version}" | ||
| substituteInPlace Makefile --replace-fail "REVISION := \$(shell git rev-parse --short=8 HEAD || echo unknown)" "REVISION := v${version}" |
Contributor
There was a problem hiding this comment.
Perhaps I am wrong but, I think the .git folder is stripped out, so git rev-parse won't work.
Have you tested this?
Member
Author
There was a problem hiding this comment.
That's correct. I switched back to draft, as I made a mistake while pushing. 17.9.2 introduced further changes (mroe tests fail when not there is no .git directory). I'm currently trying some more things...
drupol
reviewed
Mar 27, 2025
Comment on lines
+76
to
+77
| mkdir $out/bin | ||
| cp out/binaries/gitlab-runner-$GOOS-$GOARCH $out/bin/gitlab-runner |
Contributor
There was a problem hiding this comment.
install -Dm755 out/binaries/gitlab-runner-$GOOS-$GOARCH "$out/bin/gitlab-runner"
13 tasks
wegank
added
the
2.status: merge conflict
13 tasks
Member
|
Done in #396939. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
superseedes #356040
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.